Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quiet down noisy console logs from determineCanonical #3192

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: quiet down noisy console logs from determineCanonical #3192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/theme/DocItem/Metadata/determineCanonical.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function determineCanonicalFromDoc(currentDoc, currentPlugin) {
.find((doc) => doc.id === unversionedId);

if (match) {
if (/(optimize|docs)((next|[0-9\.]*)\/)/.test(match.path)) {
if (/(optimize|docs)\/((next|[0-9\.]+)\/)/.test(match.path)) {
Copy link
Collaborator Author

@pepopowitz pepopowitz Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old regex was matching every single doc, because it was only requiring the optimize|docs at the beginning

// This finds docs whose matches are non-latest versions.
// These docs would probably benefit from adding canonical frontmatter.
console.log(
Expand Down
Loading