Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust redirect for grpc link #3690

Merged
merged 1 commit into from
Apr 19, 2024
Merged

adjust redirect for grpc link #3690

merged 1 commit into from
Apr 19, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Closes https://github.com/camunda/doc-hospital/issues/14.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@christinaausley christinaausley added the component:zeebe Issues related with Zeebe project label Apr 18, 2024
@christinaausley christinaausley self-assigned this Apr 18, 2024
@@ -652,7 +652,7 @@ RewriteRule ^docs/reference/tasklist-api(.*)$ /docs/apis-clients/tasklist-api$1
RewriteRule ^docs/reference/tasklist-api$ /docs/apis-clients/tasklist-api [R=301,L]

RewriteRule ^docs/reference/public-api/$ /docs/apis-clients/public-api [R=301,L]
RewriteRule ^docs/reference/grpc/$ /docs/apis-clients/grpc [R=301,L]
RewriteRule ^docs/reference/grpc/?$ /docs/apis-clients/grpc/ [R=301,L]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very old redirect, before we added a trailing slash.

@pepopowitz would it make sense to audit the other rules without a trailing slash too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely could, but I personally feel like that's a task that will sit on our board due to low priority and we'll never get to it. If you're feeling ambitious though, go for it!

@christinaausley christinaausley merged commit 39eb3ea into main Apr 19, 2024
10 checks passed
@christinaausley christinaausley deleted the 14-link-broken-grpc branch April 19, 2024 15:32
theburi pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:zeebe Issues related with Zeebe project
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants