Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(spring-zeebe-sdk): remove references to old annotation #3700

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

nicpuppa
Copy link
Contributor

@nicpuppa nicpuppa commented Apr 22, 2024

Description

Removed references to old @ZeebeWorker annotation, deprecated since 8.1.
Replaced with @Jobworker annotation

closes: #3699

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

Removed references to old @ZeebeWorker annotation, deprecated since 8.1.
 Replaced with @Jobworker annotation
@nicpuppa nicpuppa self-assigned this Apr 22, 2024
@nicpuppa nicpuppa marked this pull request as ready for review April 22, 2024 15:52
@nicpuppa nicpuppa added component:zeebe Issues related with Zeebe project kind/bug Issues related with bugs in the documentation labels Apr 22, 2024
Copy link
Contributor

@ana-vinogradova-camunda ana-vinogradova-camunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
❓ Where do we mention that "autoComplete" default value has changes from "false" to "true"?

@nicpuppa
Copy link
Contributor Author

nicpuppa commented Apr 23, 2024

❓ Where do we mention that "autoComplete" default value has changes from "false" to "true"?

Is already mentioned in the SDK documentation @ana-vinogradova-camunda

@nicpuppa nicpuppa merged commit 99c9fb1 into main Apr 24, 2024
15 checks passed
@nicpuppa nicpuppa deleted the 3699-remove-zeebe-worker-annotation branch April 24, 2024 10:39
theburi pushed a commit that referenced this pull request Jun 5, 2024
Removed references to old @ZeebeWorker annotation, deprecated since 8.1.
 Replaced with @Jobworker annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:zeebe Issues related with Zeebe project kind/bug Issues related with bugs in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spring Zeebe SDK] Remove @ZeebeWorker annotation references
2 participants