Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connectors): remove redundant variable from examples #3714

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

chillleader
Copy link
Member

Description

Removes the redundant variable SPRING_MAIN_WEB-APPLICATION_TYPE from examples. It's insignificant and its declaration conflits with default health indicators of the connector runtime in the newer connectors versions.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@chillleader chillleader self-assigned this Apr 25, 2024
@chillleader chillleader added the component:connectors Issues related to the connectors project. label Apr 25, 2024
@akeller akeller added the kind/bug Issues related with bugs in the documentation label Apr 26, 2024
@akeller
Copy link
Member

akeller commented Apr 26, 2024

This can merge without a technical writing review. Please reach out on ask-c8-documentation if you'd like it released immediately after.

@chillleader chillleader changed the title connectors-rm-redundant-var fix(connectors): remove redundant variable from examples Apr 29, 2024
Comment on lines 189 to 190
-e CAMUNDA_CONNECTOR_POLLING_ENABLED=false \
-e CAMUNDA_CONNECTOR_WEBHOOK_ENABLED=false \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if these are still needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are still needed if you want to disable Operate connection without breaking anything else. Thanks for checking 🙂

@chillleader chillleader merged commit ec6d283 into main Apr 29, 2024
11 checks passed
@chillleader chillleader deleted the connectors-rm-redundant-var branch April 29, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. kind/bug Issues related with bugs in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants