Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive(8.1) isolation: manual steps #3760

Merged

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented May 2, 2024

Description

Part of #3731.

Note that this targets the branch unsupported/8.1, and will never make it into main.

Manual tasks to isolate a site for version 8.1, including:

  • Update broken links
  • Modify canonical URL functionality to support absolutely-qualified URLs. This functionality will be ported to main in a separate PR.
  • Update canonicalUrl property, which was previously crossing versions, to target the supported location of the canonical Operate API Overview page.
  • Update htaccess rules

See #2832 for a comparable PR of a previous version (8.0).

This is the final PR for isolating version 8.1. After this is merged, I'll deploy the 8.1 version to unsupported.docs.camunda.io/8.1.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • There is no urgency with this change and can be released at any time.
  • My goal is to complete archival of 8.1 by the end of this week (May 3). I'd like to merge this in the next day to meet this schedule.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz self-assigned this May 2, 2024
@pepopowitz pepopowitz added kind/cleanup Issues related with clean-up the documentation component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team labels May 2, 2024
@pepopowitz pepopowitz added the hold This issue is parked, do not merge. label May 2, 2024
@pepopowitz pepopowitz mentioned this pull request May 3, 2024
@pepopowitz pepopowitz removed the hold This issue is parked, do not merge. label May 6, 2024
@pepopowitz pepopowitz requested a review from akeller May 6, 2024 19:29
@@ -44,8 +44,8 @@ Follow these steps to configure the Amazon EventBridge Connector:
- **Source**: Enter the value that identifies the service that generated the event.
- **Detail type**: Enter the type of event being sent. Refer to the [Amazon documentation](https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-events-structure.html) for more information on these properties.
5. In the **Event Payload** section, enter a JSON object that contains information about the event.
6. (Optional) In the **Output Mapping** section, you can set a **Result variable** or **Result expression**. Refer to the [response mapping documentation](/docs/components/connectors/use-connectors/index.md#response-mapping) to learn more.
7. (Optional) In the **Error Handling** section, define the **Error expression** to handle errors that may occur during the event sending process. Refer to the [response mapping documentation](/docs/components/connectors/use-connectors/index.md#bpmn-errors) to learn more.
6. (Optional) In the **Output Mapping** section, you can set a **Result variable** or **Result expression**. Refer to the [response mapping documentation](components/connectors/use-connectors/index.md#variableresponse-mapping) to learn more.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links updated in this PR seem to be missing the first /. I think you only want to remove /docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally removed /docs/ including slashes on both sides, because I associate markdown links that begin with a / as typically referencing /docs, and ending in a cross-instance link (which these don't do, but it's muscle memory I guess). I don't really have a preference since both resolve to the correct place. Is this feedback blocking?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, just wanted to make sure it was intentional since other links in these same files are /components/ vs. components/

@pepopowitz pepopowitz merged commit b157368 into unsupported/8.1 May 6, 2024
7 of 9 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/3731-81-archival/3-manual-steps branch May 6, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content dx Documentation infrastructure typically handled by the Camunda DX team kind/cleanup Issues related with clean-up the documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants