Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi #3770

Merged
merged 6 commits into from
May 7, 2024

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented May 6, 2024

This PR contains a ton of removed files! Viewing "Files changed" will crash your browser.

It targets the branch from #3769, since that one should merge first.

BLOCKED

Description

Part of #3731.

Deletes the 8.1/3.9.0 content from the docs. This is the final step in archiving this unsupported version.

Since it's hard to view in the browser, these are the commands I ran for this PR:

rm -rf ./versioned_docs/version-8.1/
rm ./versioned_sidebars/version-8.1-sidebars.json
rm -rf ./optimize_versioned_docs/version-3.9.0/
rm ./optimize_versioned_sidebars/version-3.9.0-sidebars.json

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • There is no urgency with this change and can be released at any time.
  • In the next couple days, preferably, so I can complete this archival work.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz self-assigned this May 6, 2024
@pepopowitz pepopowitz changed the title archive(8.1) isolation: incorporate recent changes archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi May 6, 2024
@pepopowitz pepopowitz requested a review from akeller May 6, 2024 21:39
@pepopowitz pepopowitz added kind/cleanup Issues related with clean-up the documentation dx Documentation infrastructure typically handled by the Camunda DX team hold This issue is parked, do not merge. labels May 6, 2024
@pepopowitz pepopowitz changed the title archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi [BLOCKED] archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi May 6, 2024
@pepopowitz pepopowitz changed the title [BLOCKED] archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi [DO NOT MERGE] archive(8.1) exclude: remove versions 8.1 and 3.9.0, part 2: chonky boi May 6, 2024
@pepopowitz pepopowitz mentioned this pull request May 6, 2024
akeller
akeller previously approved these changes May 6, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hand wavy review because that's all I can do (can barely type TBH)

Base automatically changed from pepopowitz/3731-81-archival/exclude-reviewable to main May 7, 2024 15:45
@pepopowitz pepopowitz dismissed akeller’s stale review May 7, 2024 15:45

The base branch was changed.

@pepopowitz
Copy link
Collaborator Author

Sorry to do this @akeller but could I get another approval on this? I merged the other related PR, resulting in this one changing targets to main (as expected)...and it dismissed your approval.

For what it's worth, if approving through the UI is completely unbearable due to the massive quantity of changes, the GitHub CLI provides a method for reviewing/approving from your terminal: https://cli.github.com/manual/gh_pr_review

@pepopowitz pepopowitz requested a review from akeller May 7, 2024 15:47
@pepopowitz pepopowitz removed the hold This issue is parked, do not merge. label May 7, 2024
@pepopowitz
Copy link
Collaborator Author

Merging in a red state -- this is as green as it's going to get, because the massive quantity of changes breaks the two failing checks.

@pepopowitz pepopowitz merged commit 9b3b101 into main May 7, 2024
11 of 18 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/3731-81-archival/exclude-chonky-boi branch May 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/cleanup Issues related with clean-up the documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants