Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(optimize): document SNI configuration options #3788

Merged
merged 2 commits into from
May 17, 2024

Conversation

buccarel
Copy link
Contributor

@buccarel buccarel commented May 10, 2024

Description

Context:
https://github.com/camunda/camunda-optimize/issues/11941

With this PR, we are adding the documentation about the option to enable or disable the SNI check.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@buccarel buccarel requested a review from RomanJRW May 10, 2024 10:28
@buccarel buccarel self-assigned this May 10, 2024
@buccarel buccarel marked this pull request as ready for review May 10, 2024 14:00
@christinaausley christinaausley added component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels May 10, 2024
Copy link
Contributor

@RomanJRW RomanJRW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, just a change in the default values please 🙂

@akeller
Copy link
Member

akeller commented May 13, 2024

@buccarel since we have an alpha release tomorrow, we'll do doing at least one docs release this week (later today). If you get this cleaned up, we can include it!

@RomanJRW
Copy link
Contributor

@buccarel has FTO for the next few days. Given that this is not new functionality, I don't see the need to find someone on the team to take over in his absence and it can wait until his return

@buccarel buccarel requested a review from RomanJRW May 17, 2024 08:04
@RomanJRW RomanJRW merged commit a19220e into main May 17, 2024
7 checks passed
@RomanJRW RomanJRW deleted the document-toggle-sni-check branch May 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants