Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment source as Camunda Modeler #1153

Closed
ingorichtsmeier opened this issue Jan 31, 2019 · 5 comments
Closed

Add deployment source as Camunda Modeler #1153

ingorichtsmeier opened this issue Jan 31, 2019 · 5 comments
Assignees
@nikku
Labels
deploy enhancement New feature or request good first issue Good for newcomers

Comments

@ingorichtsmeier
Copy link

Is your feature request related to a problem? Please describe.

When I deploy a process from the modeler, I could not find any hint where the process definition comes from. Source is null.

grafik

Describe the solution you'd like

I would like to see on the deployment page in Camunda cockpit, that the deployment was done from the Camunda Modeler

Describe alternatives you've considered

this is 'Alternativlos'

Additional context

Solution is to add a form field name=depolyment-source, value=Camunda Modeler (maybe the version, if it's available). Should be an easy pick.
@nikku nikku added enhancement New feature or request deploy good first issue Good for newcomers ready Ready to be worked on labels Jan 31, 2019
@nikku nikku mentioned this issue Jan 31, 2019
Closed
25 tasks
nikku added a commit that referenced this issue Jan 31, 2019
@nikku
feat(deploy): set deployment-source to Camunda Modeler
701fc5c 
Closes #1153
@ghost ghost assigned nikku Jan 31, 2019
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Jan 31, 2019
nikku added a commit that referenced this issue Jan 31, 2019
@nikku
feat(deploy): set deployment-source to Camunda Modeler
6e5a481 
Closes #1153
@nikku nikku mentioned this issue Jan 31, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 31, 2019
@nikku
Copy link
Member

nikku commented Jan 31, 2019

It is indeed an easy pick that is worth implementing right now.

We can refine the source string in the future, possibly adding version, env, ...

image

@nikku
Copy link
Member

nikku commented Jan 31, 2019

Will be addressed via #1154.

merge-me bot pushed a commit that referenced this issue Jan 31, 2019
@nikku @merge-me
feat(deploy): set deployment-source to Camunda Modeler
c5e63e2 
Closes #1153
@barmac
Copy link
Contributor

barmac commented Jan 31, 2019

Closed via #1154

@barmac barmac closed this as completed Jan 31, 2019
@ghost ghost removed the needs review Review pending label Jan 31, 2019
@ingorichtsmeier
Copy link
Author

Great, Thank you. What are your plans to release a new preview version where this is included?

@nikku
Copy link
Member

nikku commented Jan 31, 2019

Next pre-release is pending a few issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
deploy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikku @ingorichtsmeier @barmac