Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save as button should be disabled for EmptyTab #1282

Closed
barmac opened this issue Mar 4, 2019 · 1 comment
Closed

Save as button should be disabled for EmptyTab #1282

barmac opened this issue Mar 4, 2019 · 1 comment
Assignees
Labels
bug Something isn't working refactoring
Milestone

Comments

@barmac
Copy link
Contributor

barmac commented Mar 4, 2019

Describe the Bug

Save as button is enabled for empty tab and it causes an unhandled Promise rejection on backend. The issue did not occur in Camunda Modeler 2.2.4.

screenshot 2019-03-04 at 11 35 51

Steps to Reproduce

  1. Open Camunda Modeler and close all tabs.
  2. Click on save as button.

There is an unhandled Promise rejection on backend, see log below:

(node:76526) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'path' of undefined
    at /Users/maciej.barelkowski/workspace/bpmn-io/camunda-modeler/app/lib/index.js:169:12
    at EventEmitter.<anonymous> (/Users/maciej.barelkowski/workspace/bpmn-io/camunda-modeler/app/lib/util/renderer.js:39:14)
    at EventEmitter.emit (events.js:182:13)
    at WebContents.<anonymous> (/Users/maciej.barelkowski/workspace/bpmn-io/camunda-modeler/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:285:13)
    at WebContents.emit (events.js:182:13)
(node:76526) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:76526) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
app:main window focused

Expected Behavior

Button should be disabled and no message to backend should be sent.

Environment

  • OS: MacOS
  • Camunda Modeler Version: master
@barmac barmac added bug Something isn't working refactoring ready Ready to be worked on labels Mar 4, 2019
@barmac barmac added this to the M28 milestone Mar 4, 2019
@pinussilvestrus pinussilvestrus added in progress Currently worked on and removed ready Ready to be worked on labels Mar 5, 2019
@pinussilvestrus pinussilvestrus self-assigned this Mar 5, 2019
pinussilvestrus pushed a commit that referenced this issue Mar 5, 2019
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Mar 5, 2019
merge-me bot pushed a commit that referenced this issue Mar 5, 2019
@pinussilvestrus
Copy link
Contributor

Closed via #1285

@ghost ghost removed the needs review Review pending label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring
Projects
None yet
Development

No branches or pull requests

2 participants