Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having NODE_ENV=development defined breaks starting the app #1352

Closed
nikku opened this issue Apr 24, 2019 · 2 comments · Fixed by #1360
Closed

Having NODE_ENV=development defined breaks starting the app #1352

nikku opened this issue Apr 24, 2019 · 2 comments · Fixed by #1360
Assignees
@philippfromme
Labels
bug Something isn't working
Milestone
M28.2

Comments

@nikku
Copy link
Member

nikku commented Apr 24, 2019

Describe the Bug

If I have a global NODE_ENV=development variable defined the app thinks it is in development mode. As a result, it attempts to load the wrong entry file and explodes on open.

Cf. zeebe-io/zeebe-modeler#73 for downstream bug.

Steps to Reproduce

  • Define NODE_ENV=development
  • Start app

Expected Behavior

NODE_ENV is ignored in production app.

Environment

  • OS: Any
  • Camunda Modeler Version: v3.0.1
@nikku nikku added backlog Queued in backlog bug Something isn't working labels Apr 24, 2019
@nikku nikku mentioned this issue Apr 24, 2019
Closed
philippfromme added a commit that referenced this issue Apr 26, 2019
@philippfromme
feat(app): ensure production mode in distro
4b29600 
Closes #1352
@ghost ghost assigned philippfromme Apr 26, 2019
@ghost ghost added in progress Currently worked on and removed backlog Queued in backlog labels Apr 26, 2019
@philippfromme philippfromme mentioned this issue Apr 26, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Apr 26, 2019
philippfromme added a commit that referenced this issue Apr 26, 2019
@philippfromme
feat(app): ensure production mode in distro
9124634 
Closes #1352
merge-me bot pushed a commit that referenced this issue Apr 26, 2019
@philippfromme @merge-me
feat(app): ensure production mode in distro
a09edba 
Closes #1352
@nikku nikku added this to the M29 milestone Apr 26, 2019
@nikku
Copy link
Member Author

nikku commented Apr 26, 2019

Closed via #1360

@nikku nikku closed this as completed Apr 26, 2019
@ghost ghost removed the needs review Review pending label Apr 26, 2019
@nikku
Copy link
Member Author

nikku commented Apr 26, 2019

Released as v3.1.0

@nikku nikku modified the milestones: M29, M28.2 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working
Projects
None yet
Milestone
M28.2
Development

Successfully merging a pull request may close this issue.

Ensure Production Mode in Distro camunda/camunda-modeler
2 participants
@nikku @philippfromme