Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First time trying to close "Deploy Diagram" dialog leads to error "Deployment name must not be void." #1405

Closed
Endogen opened this issue Jun 13, 2019 · 2 comments
Closed

First time trying to close "Deploy Diagram" dialog leads to error "Deployment name must not be void." #1405

Endogen opened this issue Jun 13, 2019 · 2 comments
Assignees
@barmac
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
M29.1

Comments

@Endogen
Copy link

Endogen commented Jun 13, 2019 •
edited by nikku
Loading

Describe the Bug
Opening the "Deploy Diagram" dialog and immediately closing it with the Close-button leads to the error "Deployment name must not be void.". After clicking the button again, the dialog closes.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Open dialog "Deploy Diagram"
  2. Click button "Cancel"

Expected Behavior
After clicking the Close-button, the dialog should close without the error message

Environment

  • OS: Windows 7
  • Camunda Modeler Version: 3.1.2

Child of #1439
@pinussilvestrus
Copy link
Contributor

Confirmed on macOS with modeler version 3.1.2 and current master.

Jun-19-2019 09-39-35

Let's tackle this when we improve the deploy functionality in the next quarter! Or what do you think @nikku @volkergersabeck ?

@pinussilvestrus pinussilvestrus added the bug Something isn't working label Jun 19, 2019
@nikku nikku added backlog Queued in backlog good first issue Good for newcomers labels Jun 24, 2019
@nikku
Copy link
Member

nikku commented Jun 24, 2019

Makes sense, as this is a very nice easy pick.

@nikku nikku added this to the M30 milestone Jun 24, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 8, 2019 — with bpmn-io-tasks
barmac added a commit that referenced this issue Jul 24, 2019
@barmac
fix(deploy): run validation only after first submit
d781a75 
Closes #1405
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jul 24, 2019
barmac added a commit that referenced this issue Jul 24, 2019
@barmac
fix(deploy): display validation result only after first submission
24248c4 
Closes #1405
@barmac barmac mentioned this issue Jul 24, 2019
Closed
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 24, 2019
This was referenced Jul 24, 2019
Merged
Closed
@nikku nikku closed this as completed in 721d347 Jul 25, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 25, 2019
@nikku nikku modified the milestones: M30, M29.1 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
M29.1
Development

Successfully merging a pull request may close this issue.

fix(deploy): display validation result only after first submission camunda/camunda-modeler
4 participants
@nikku @Endogen @pinussilvestrus @barmac