Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy&Paste restricted by improved container navigation #1416

Closed
1 task
mschoe opened this issue Jun 28, 2019 · 8 comments
Closed
1 task

Copy&Paste restricted by improved container navigation #1416

mschoe opened this issue Jun 28, 2019 · 8 comments
Labels
bug Something isn't working
Milestone
M30

Comments

@mschoe
Copy link
Member

mschoe commented Jun 28, 2019 •
edited by nikku
Loading

Describe the Bug

Given the new container interaction you cannot paste into containers anymore.

Reproduce

  • create a pool or sub process that contains at least one element
  • select the element and copy it
  • hover over the pool
  • trigger paste
  • paste is restricted or, if possible paste happens outside the container element
    ezgif-2-d5fa4140f9a4
    ezgif-2-04989fedc2a3

Expected Behavior

  • Pasting elements works without hazzles like in Camunda Modeler v3.1

Environment

Please complete the following information:

  • OS: Any
  • Camunda Modeler Version: 3.2-nightly
@mschoe mschoe added the bug Something isn't working label Jun 28, 2019
@nikku
Copy link
Member

nikku commented Jun 28, 2019

This is a UX issue that got introduced via #238.

@nikku nikku added this to the M29 milestone Jun 28, 2019
@nikku nikku added the ready Ready to be worked on label Jun 28, 2019
@barmac
Copy link
Contributor

barmac commented Jun 28, 2019

Idea: allow paste if participant is selected.

@barmac barmac added in progress Currently worked on and removed ready Ready to be worked on labels Jun 28, 2019 — with bpmn-io-tasks
@barmac barmac self-assigned this Jun 28, 2019
@nikku
Copy link
Member

nikku commented Jun 28, 2019

That is the idea worth exploring 👍

@barmac
Copy link
Contributor

barmac commented Jul 1, 2019

Paste-on-selection approach does not fix another problem related to this issue, cf.:

paste

@barmac
Copy link
Contributor

barmac commented Jul 1, 2019

Second idea: Use rules to introduce the improved navigation. This way we could potentially resolve the current issue and save the feature.

@barmac
Copy link
Contributor

barmac commented Jul 1, 2019

We decided to revert the improved navigation and return back to it in the future.

barmac added a commit to bpmn-io/bpmn-js that referenced this issue Jul 1, 2019
@barmac
Revert "feat(modeling): prevent accidential dragging of container ele…
def6ec3 
…ments"

This reverts commit 7b0e304.

Closes camunda/camunda-modeler#1416
Opens #957
@barmac barmac mentioned this issue Jul 1, 2019
Merged
barmac added a commit to bpmn-io/bpmn-js that referenced this issue Jul 2, 2019
@barmac
Revert "feat(modeling): prevent accidential dragging of container ele…
97a04be 
…ments"

This reverts commit 7b0e304.

Related to camunda/camunda-modeler#1416
Opens #957
merge-me bot pushed a commit to bpmn-io/bpmn-js that referenced this issue Jul 2, 2019
@barmac @merge-me
Revert "feat(modeling): prevent accidential dragging of container ele…
23505a4 
…ments"

This reverts commit 7b0e304.

Related to camunda/camunda-modeler#1416
Opens #957
@barmac barmac added the fixed upstream Requires integration of upstream change label Jul 2, 2019
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed in progress Currently worked on labels Jul 2, 2019 — with bpmn-io-tasks
@barmac
Copy link
Contributor

barmac commented Jul 2, 2019

Fixed via 7c48975

@barmac barmac closed this as completed Jul 2, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jul 2, 2019
@nikku nikku mentioned this issue Jul 5, 2019
Closed
2 tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label Jul 5, 2019
@nikku nikku modified the milestones: M29, M30 Jul 5, 2019
@nikku nikku reopened this Jul 5, 2019
@nikku nikku mentioned this issue Jul 5, 2019
Closed
5 tasks
@nikku
Copy link
Member

nikku commented Jul 5, 2019

We investigate two-step pasting as a solution for this issue: #1421

@nikku nikku added the ready Ready to be worked on label Jul 5, 2019 — with bpmn-io-tasks
@barmac barmac removed their assignment Jul 5, 2019
@nikku nikku added in progress Currently worked on and removed ready Ready to be worked on labels Aug 9, 2019 — with bpmn-io-tasks
@nikku nikku closed this as completed in 27a2a83 Aug 9, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
M30
Development

No branches or pull requests
4 participants
@nikku @mschoe @pinussilvestrus @barmac