Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping Data Store on Group border freezes editor #1431

Closed
1 task
nikku opened this issue Jul 22, 2019 · 2 comments
Closed
1 task

Dropping Data Store on Group border freezes editor #1431

nikku opened this issue Jul 22, 2019 · 2 comments
Labels
BPMN bug Something isn't working modeling
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Jul 22, 2019

Describe the Bug

Dropping a data store on a group frame is currently allowed. Doing it results in the BPMN editor freezing (throwing an exception on drop):

capture sK6UQI_optimized

Steps to Reproduce

  • Model a Group
  • Drop Data Store from palette onto group

Expected Behavior

  • Data store cannot be dropped on group

Environment

Please complete the following information:

  • OS: Any
  • Camunda Modeler Version: v3.2.0
@nikku nikku added bug Something isn't working BPMN modeling labels Jul 22, 2019
@nikku nikku mentioned this issue Jul 22, 2019
Closed
21 tasks
nikku added a commit to bpmn-io/bpmn-js that referenced this issue Jul 22, 2019
@nikku
fix(rules): disallow dropping on labels and groups
c84611a 
* test create
* disallow drop on label
* disallow drop on group
* verify create group everywhere

Required by camunda/camunda-modeler#1431
@nikku
Copy link
Member Author

nikku commented Jul 22, 2019

Blows up editor when dropping on labels, too.

@nikku
Copy link
Member Author

nikku commented Jul 22, 2019

Fix incoming via bpmn-io/bpmn-js#1131.

@nikku nikku added this to the M29 milestone Jul 22, 2019
@nikku nikku added the needs review Review pending label Jul 22, 2019
@nikku nikku mentioned this issue Jul 22, 2019
Closed
barmac pushed a commit to bpmn-io/bpmn-js that referenced this issue Jul 22, 2019
@nikku @barmac
fix(rules): disallow dropping on labels and groups
962f2d5 
* test create
* disallow drop on label
* disallow drop on group
* verify create group everywhere

Required by camunda/camunda-modeler#1431
@barmac barmac mentioned this issue Jul 22, 2019
Merged
barmac pushed a commit to bpmn-io/bpmn-js that referenced this issue Jul 22, 2019
@nikku @barmac
fix(rules): disallow dropping on labels and groups
e7d66b4 
* test create
* disallow drop on label
* disallow drop on group
* verify create group everywhere

Required by camunda/camunda-modeler#1431
@nikku nikku closed this as completed in 1c0a3dc Jul 22, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 22, 2019
nikku added a commit that referenced this issue Jul 23, 2019
@nikku
chore(client): bump bpmn-js
5c0148c 
Closes #1431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Milestone
M29
Development

No branches or pull requests
1 participant
@nikku