Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest Electron #1448

Closed
3 tasks done
nikku opened this issue Aug 1, 2019 · 0 comments · Fixed by #1454
Closed
3 tasks done

Update to latest Electron #1448

nikku opened this issue Aug 1, 2019 · 0 comments · Fixed by #1454
Assignees
@nikku
Labels
infrastructure
Milestone
M33

Comments

@nikku
Copy link
Member

nikku commented Aug 1, 2019 •
edited

Electron 6 got released and as a result, support for Electron 3 got dropped. This means we won't get fixes for Electron 3 anymore and should consider the update to the latest version.

In the mean time, Electron 7 got released, too.

A first investigation showed that the new version is not a drop-in replacement for us. It disables node integration per default (which is a good thing). That requires additional work on our side though.

Tasks
@nikku nikku self-assigned this Aug 1, 2019
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
feat(client): disable node integration
9db8161 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

This also refactors the way we expose meta-data
from the app (aligns it with plugins and flags).

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~

test(client/remote): update PluginsSpec
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
chore(project): bump to Electron@6
caee54e 
Closes #1448
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
feat(client): disable node integration
7596daa 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

This also refactors the way we expose meta-data
from the app (aligns it with plugins and flags).

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~

test(client/remote): update PluginsSpec
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
chore(project): bump to Electron@6
6489ea8 
Closes #1448
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
feat(client): disable node integration
eb251a5 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
nikku added a commit that referenced this issue Aug 1, 2019
@nikku
chore(project): bump to Electron@6
ef83c65 
Closes #1448
@nikku nikku added the in progress Currently worked on label Aug 1, 2019
nikku added a commit that referenced this issue Aug 2, 2019
@nikku
feat(client): disable node integration
fc859d3 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
nikku added a commit that referenced this issue Aug 2, 2019
@nikku
chore(project): bump to Electron@6
10506e2 
Closes #1448
@nikku nikku mentioned this issue Aug 2, 2019
Merged
3 tasks
nikku added a commit that referenced this issue Aug 6, 2019
@nikku
feat(client): disable node integration
c249ad1 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
nikku added a commit that referenced this issue Aug 7, 2019
@nikku
feat(client): disable node integration
e6b4e32 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
nikku added a commit that referenced this issue Aug 7, 2019
@nikku
feat(client): disable node integration
f655b82 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
barmac pushed a commit that referenced this issue Aug 7, 2019
@nikku @barmac
feat(client): disable node integration
92ba66d 
This is a security threat that we want to avoid.
We should expose backend utilities by other means.

Related to #1448

BREAKING CHANGE:

* This breaks plug-ins that depend on the standard
  Electron behavior (nodeIntegration=true). We are
  Better of without these plug-ins, probably. ~_~
@nikku nikku added backlog Queued in backlog and removed in progress Currently worked on labels Aug 12, 2019 — with bpmn-io-tasks
@nikku nikku changed the title Update to Electron@6 Update to latest Electron Nov 27, 2019
@nikku nikku mentioned this issue Nov 27, 2019
Closed
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Dec 11, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M34 milestone Dec 11, 2019
nikku added a commit that referenced this issue Dec 17, 2019
@nikku
chore(project): bump to Electron@7
e0b567e 
Closes #1448
nikku added a commit that referenced this issue Dec 17, 2019
@nikku
chore(project): bump to Electron@7
c121f80 
Closes #1448
nikku added a commit that referenced this issue Dec 17, 2019
@nikku
chore(project): bump to Electron@7
d16bb83 
Closes #1448
@bpmn-io-tasks bpmn-io-tasks bot added backlog Queued in backlog needs review Review pending and removed ready Ready to be worked on backlog Queued in backlog labels Dec 17, 2019
@bpmn-io-tasks bpmn-io-tasks bot added ready Ready to be worked on and removed needs review Review pending labels Dec 18, 2019
nikku added a commit that referenced this issue Jan 6, 2020
@nikku
chore(project): bump to Electron@7
c2b3bd0 
Closes #1448
@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels Jan 6, 2020 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added ready Ready to be worked on and removed needs review Review pending labels Jan 8, 2020
@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels Jan 8, 2020 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added ready Ready to be worked on and removed needs review Review pending labels Jan 8, 2020
nikku added a commit that referenced this issue Jan 9, 2020
@nikku
chore(project): bump to Electron@7
3582777 
Closes #1448
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jan 9, 2020
@nikku nikku modified the milestones: M34, M33 Jan 9, 2020
@nikku nikku mentioned this issue Jan 22, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
infrastructure
Projects
None yet
Milestone
M33
Development

Successfully merging a pull request may close this issue.

Update to Electron 7 camunda/camunda-modeler
1 participant
@nikku