Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find shortcut disabled for no reason #1450

Closed
barmac opened this issue Aug 1, 2019 · 5 comments · Fixed by #1461
Closed

Find shortcut disabled for no reason #1450

barmac opened this issue Aug 1, 2019 · 5 comments · Fixed by #1461
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M30

Comments

@barmac
Copy link
Contributor

barmac commented Aug 1, 2019 •
edited by nikku
Loading

Describe the Bug

The "Find" shortcut stops to work after the first use in a tab. Then it comes back when the tab is switched.

Steps to Reproduce

  1. Open a new tab.
  2. Use Find shortcut (Cmd+F).
  3. Notice that the menu item is disabled and the shortcut does not work anymore.

Expected Behavior

Find shortcut still works.

Environment

  • OS: MacOS, Linux
  • Camunda Modeler Version: 3.2.1
@barmac barmac added the bug Something isn't working label Aug 1, 2019
@nikku
Copy link
Member

nikku commented Aug 9, 2019

Same on Linux. Menu item is disabled, you can still open the search box sporadically though.

@nikku
Copy link
Member

nikku commented Aug 9, 2019

Were you able to get to the root of this issue?

@barmac
Copy link
Contributor Author

barmac commented Aug 9, 2019

Nope, but I didn't debug it thoroughly.

@barmac
Copy link
Contributor Author

barmac commented Aug 9, 2019

BpmnEditor#handleChanged is not triggered when we exit the Find input without selecting an element. This seems to be an easy fix.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 9, 2019
barmac added a commit that referenced this issue Aug 9, 2019
@barmac
fix(editors): fire state updates on search pad opened/closed
bf83516 
Closes #1450
@barmac barmac mentioned this issue Aug 9, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 9, 2019
@nikku nikku added this to the M30 milestone Aug 9, 2019
@nikku
Copy link
Member

nikku commented Aug 9, 2019

Closed via #1461.

@nikku nikku closed this as completed Aug 9, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 9, 2019
philippfromme pushed a commit that referenced this issue Aug 22, 2019
@barmac @merge-me
fix(editors): fire state updates on search pad opened/closed
409ef23 
Closes #1450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M30
Development

Successfully merging a pull request may close this issue.

fix(editors): fire state updates on search pad opened/closed camunda/camunda-modeler
2 participants
@nikku @barmac