Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPMN Group is not being colored #1598

Closed
1 task
nikku opened this issue Nov 25, 2019 · 3 comments · Fixed by #1608
Closed
1 task

BPMN Group is not being colored #1598

nikku opened this issue Nov 25, 2019 · 3 comments · Fixed by #1608
Labels
BPMN bug Something isn't working modeling
Milestone
M32

Comments

@nikku
Copy link
Member

nikku commented Nov 25, 2019

Describe the Bug

BPMN groups ignore the color that is assigned to them:

image

Steps to Reproduce

  • Open test diagram
  • Select all elements
  • Color elements (any color)
  • Group keeps black color

Expected Behavior

  • Group adapts border color, as specified.

Environment

  • OS: Any
  • Camunda Modeler Version: v3.4.1, v3.5 (also Zeebe Modeler v0.8.0)
@nikku nikku mentioned this issue Nov 25, 2019
Closed
51 tasks
@nikku nikku added BPMN bug Something isn't working modeling labels Nov 25, 2019
@pinussilvestrus
Copy link
Contributor

We simply not setting the stroke color in BpmnRenderer

Should be easy to fix by getStrokeColor(element, defaultStrokeColor)

nikku added a commit to bpmn-io/bpmn-js that referenced this issue Nov 25, 2019
@nikku
fix(draw): render colored BPMN group elements
5b7bafc 
Related to camunda/camunda-modeler#1598
@nikku nikku mentioned this issue Nov 25, 2019
Merged
@nikku
Copy link
Member Author

nikku commented Nov 25, 2019

That was indeed it:

image

Fix incoming via bpmn-io/bpmn-js#1246.

nikku added a commit to bpmn-io/bpmn-js that referenced this issue Nov 25, 2019
@nikku
fix(draw): render colored BPMN group elements
105cf00 
Related to camunda/camunda-modeler#1598
fake-join bot pushed a commit to bpmn-io/bpmn-js that referenced this issue Nov 25, 2019
@nikku @fake-join
fix(draw): render colored BPMN group elements
6527e7d 
Related to camunda/camunda-modeler#1598
@pinussilvestrus pinussilvestrus added the fixed upstream Requires integration of upstream change label Nov 25, 2019
nikku added a commit that referenced this issue Nov 25, 2019
@nikku
chore(client): update to diagram-js@6.0.2 / bpmn-js@6.0.3
32931c5 
Closes #1599
Closes #1598
@nikku nikku mentioned this issue Nov 25, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 25, 2019
@nikku nikku added this to the M32 milestone Nov 25, 2019
@pinussilvestrus
Copy link
Contributor

Closed via b9b5bdc

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 26, 2019
philippfromme pushed a commit that referenced this issue Nov 26, 2019
@nikku @merge-me
chore(client): update to diagram-js@6.0.2 / bpmn-js@6.0.3
b9b5bdc 
Closes #1599
Closes #1598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Milestone
M32
Development

Successfully merging a pull request may close this issue.

chore(client): update to diagram-js@6.0.2 / bpmn-js@6.0.3 camunda/camunda-modeler
2 participants
@nikku @pinussilvestrus