Illegal IDs may be entered via properties panel

[nikku]

Describe the Bug

Starting with v3.2.0 we enforce that XML IDs generated by the application are valid QNames. as #1622 indicates users are still able to input now illegal IDs, i.e. ${FOO}. Saving the diagram and re-opening it in the modeler fails the import.

Steps to Reproduce

1. open process
2. using our properties panel controls change any ID to ${FOO}
3. save diagram
4. re-open diagram
5. see that import blows up

Expected Behavior

• Valid IDs are enforced in all property panel controls that allow users to edit IDs
• Illegal IDs may not be saved by the user

Environment

• OS: Any
• Camunda Modeler Version: v3.2.0, ..., v3.5.0

---

Tasks

• Fixed in properties panels
• Released fixes
• Integrated in Camunda Modeler

[oguzeroglu]

Valid IDs are enforced in all places where we allow users to edit IDs

Does this concern the XML edit as well @nikku?

[nikku]

You mean the XML editor? No. If people enter invalid IDs into the XML view the problem will be caught on import and properly indicated.

Adding validation on the XML view would be another related feature request.

[oguzeroglu]

For reference: The problem seems to be here as after this operation ${FOO} becomes FOO so it passes the QName regex test.

[nikku]

Yes. This was intentional in the past but is not desired anymore.

[nikku]

Needs release of fixes in all libraries and integration into Camunda Modeler.

[nikku]

Closed via f906e14.