Impossible to export image #1699

nicolas-75 · 2020-02-21T19:10:00Z

Describe the Bug

Impossible to export image. When I do that a popup as filename and filetype then warn :

File could not be exported
Error:
Cannot destructure property 'encoding' of '(intermediate value)-(intermediate value)(intermediate value)' as it is undefined.
Cancel / Export as ...

I had the same error with all the filetype I tried.

Steps to Reproduce

Open Camunda Modeler
Create new diagram or Open a diagram (BPMN processes or other)
Clic on menu File -> Export as Image
Choose a name then validate
See the warning error message

Expected Behavior

The image is exported instead of a popup warning message

Environment

OS: Linux Manjaro
Camunda Modeler Version: 3.6.0

Blocked by electron/electron#21170

pinussilvestrus · 2020-02-24T08:15:47Z

Which image type to you choose for the export? .png, .jpg, .svg?

nicolas-75 · 2020-02-24T08:24:03Z

Which image type to you choose for the export? .png, .jpg, .svg?

I had the same error with all the filetype I tried. .png, .jpg, .svg?

I had the error even if the diagram is empty. I try with the nightly builds too.

The verbose on terminal when I open the software, add new diagram, export, clic on Cancel when the error popup was displayed:

$ INFO app:main:bootstrap starting Camunda Modeler v3.6.0
INFO app:cli parsing [ '/opt/camunda-modeler/camunda-modeler' ] in '/home/nicolas'
INFO app:flags searching for flags.json in paths [
'/opt/camunda-modeler/resources',
'/home/nicolas/.config/camunda-modeler/resources'
]
INFO app:flags found []
INFO app:flags active {}
INFO app:plugins searching for plugins/*/index.js in paths [
'/opt/camunda-modeler',
'/opt/camunda-modeler/resources',
'/home/nicolas/.config/camunda-modeler/resources',
'/home/nicolas/.config/camunda-modeler'
]
INFO app:plugins found plug-in entries []
INFO app:plugins registered []
INFO app:main:bootstrap received ready
[3566:0224/092049.705179:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
INFO app:main window focused
INFO app:main:bootstrap received client-ready
INFO app:workspace saving
INFO app:workspace saving
INFO app:main window focused
INFO app:main window focused

oguzeroglu · 2020-02-24T08:28:27Z

Looks like an OS related issue, let's see if we can reproduce this on a Linux Manjaro distro. Thanks for reporting!

oguzeroglu · 2020-02-24T08:32:40Z

After a quick research I found this one: https://stackoverflow.com/questions/58347778/electron-fix-errorbuffer-manager-cc488-displaycompositorgl-error-gl-inv

We still need to investigate the negative side effects on performance of this --disable-gpu flag though.

nicolas-75 · 2020-02-24T08:48:54Z

When I do:
$ /usr/lib/electron/electron /home/nicolas/camunda-modeler-3.6.0-linux-x64/camunda-modeler I have a lot of errors so maybe I don't do something right...

App threw an error during load
/home/nicolas/camunda-modeler-3.6.0-linux-x64/camunda-modeler:1
ELF
^

SyntaxError: Invalid or unexpected token
at Module._compile (internal/modules/cjs/loader.js:815:22)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
at Module._load (internal/modules/cjs/loader.js:648:12)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at loadApplicationPackage (/usr/lib/electron/resources/default_app.asar/main.js:109:16)
at Object. (/usr/lib/electron/resources/default_app.asar/main.js:155:9)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
A JavaScript error occurred in the main process
Uncaught Exception:
/home/nicolas/camunda-modeler-3.6.0-linux-x64/camunda-modeler:1
ELF
^

SyntaxError: Invalid or unexpected token
at Module._compile (internal/modules/cjs/loader.js:815:22)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
at Module.load (internal/modules/cjs/loader.js:735:32)
at Module._load (internal/modules/cjs/loader.js:648:12)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at loadApplicationPackage (/usr/lib/electron/resources/default_app.asar/main.js:109:16)
at Object. (/usr/lib/electron/resources/default_app.asar/main.js:155:9)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)

The app don't launch and I have to CTRL+C

pinussilvestrus · 2020-02-24T08:52:28Z

We do not support any other Linux distributions then Ubuntu so it seems like we are not able to help you. The errors might really depend on your operating system.

You can read about the supported environments in the documentation.

nikku · 2020-02-24T09:16:18Z

I was able to reproduce it (Arch Linux here). The issue is home made and occurs due to the fact how the Save As... dialog works on Linux: It does not automatically assume the file extension for the export file type.

Steps to reproduce:

Export Diagram
Choose a file name such as Foo.bpmn as a name (file format PNG is selected)
Press SAVE
Editor explodes

While...

Export Diagram
Choose a file name such as Foo.bpmn as a name (file format PNG is selected)
Need to manually rename to Foo.png
Press SAVE
Editor exports

nikku · 2020-02-24T09:17:27Z

It is quite easy to run into this bug on Linux, as the Save as... dialog does not change the entered files file extension.

nicolas-75 · 2020-02-24T09:21:43Z

Great! That's work when I add the file extension.

Thanks you! 👍

nikku · 2020-02-24T09:22:21Z

Broken upstream it seems: electron/electron#21170.

nikku · 2020-02-24T09:24:46Z

To prevent accidental overriding of the diagram, we should pass in the diagram without the extension as a file name.

pinussilvestrus · 2020-02-24T09:40:50Z

Thanks for double-checking @nikku!

This ensures that the happy path (saving without changing the file type) works on Linux. Related to #1699

Related to #1699

nikku · 2020-02-28T10:39:44Z

I've implemented a workaround via #1711.

We need to double check if that one does not break anything on MacOS and Windows though.

This ensures that the happy path (saving without changing the file type) works on Linux. Related to #1699

Related to #1699

nicolas-75 added the bug Something isn't working label Feb 21, 2020

pinussilvestrus added the help wanted Extra attention is needed label Feb 24, 2020

pinussilvestrus closed this as completed Feb 24, 2020

nikku reopened this Feb 24, 2020

nikku added backlog Queued in backlog and removed help wanted Extra attention is needed labels Feb 24, 2020

nikku added this to the M34 milestone Feb 24, 2020

nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Feb 24, 2020

nikku self-assigned this Feb 24, 2020

barmac modified the milestones: M34, M35 Feb 26, 2020

nikku added in progress Currently worked on and removed ready Ready to be worked on labels Feb 28, 2020 — with bpmn-io-tasks

nikku added a commit that referenced this issue Feb 28, 2020

chore(app/dialog): always append default file extension

872ac20

This ensures that the happy path (saving without changing the file type) works on Linux. Related to #1699

nikku added a commit that referenced this issue Feb 28, 2020

fix(client): handle unretrievable export config

b51bbc4

Related to #1699

nikku mentioned this issue Feb 28, 2020

Mitigate file Save As issue #1711

Merged

3 tasks

bpmn-io-tasks bot removed the in progress Currently worked on label Feb 28, 2020

bpmn-io-tasks bot added the needs review Review pending label Feb 28, 2020

barmac pushed a commit that referenced this issue Feb 28, 2020

chore(app/dialog): always append default file extension

d581449

This ensures that the happy path (saving without changing the file type) works on Linux. Related to #1699

barmac pushed a commit that referenced this issue Feb 28, 2020

fix(client): handle unretrievable export config

9e3f7a5

Related to #1699

nikku closed this as completed Mar 3, 2020

nikku removed the needs review Review pending label Mar 3, 2020 — with bpmn-io-tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Impossible to export image #1699

Impossible to export image #1699

nicolas-75 commented Feb 21, 2020 •

edited by nikku

Loading

pinussilvestrus commented Feb 24, 2020

nicolas-75 commented Feb 24, 2020

oguzeroglu commented Feb 24, 2020

oguzeroglu commented Feb 24, 2020 •

edited

Loading

nicolas-75 commented Feb 24, 2020

pinussilvestrus commented Feb 24, 2020 •

edited

Loading

nikku commented Feb 24, 2020

nikku commented Feb 24, 2020

nicolas-75 commented Feb 24, 2020

nikku commented Feb 24, 2020

nikku commented Feb 24, 2020

pinussilvestrus commented Feb 24, 2020

nikku commented Feb 28, 2020

Impossible to export image #1699

Impossible to export image #1699

Comments

nicolas-75 commented Feb 21, 2020 • edited by nikku Loading

pinussilvestrus commented Feb 24, 2020

nicolas-75 commented Feb 24, 2020

oguzeroglu commented Feb 24, 2020

oguzeroglu commented Feb 24, 2020 • edited Loading

nicolas-75 commented Feb 24, 2020

pinussilvestrus commented Feb 24, 2020 • edited Loading

nikku commented Feb 24, 2020

nikku commented Feb 24, 2020

nicolas-75 commented Feb 24, 2020

nikku commented Feb 24, 2020

nikku commented Feb 24, 2020

pinussilvestrus commented Feb 24, 2020

nikku commented Feb 28, 2020

nicolas-75 commented Feb 21, 2020 •

edited by nikku

Loading

oguzeroglu commented Feb 24, 2020 •

edited

Loading

pinussilvestrus commented Feb 24, 2020 •

edited

Loading