Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element template name and icon are not displayed in property panel header if template is versioned #2920

Closed
christian-konrad opened this issue Apr 16, 2022 · 4 comments
Closed

Element template name and icon are not displayed in property panel header if template is versioned #2920

christian-konrad opened this issue Apr 16, 2022 · 4 comments
Assignees
@pinussilvestrus
Labels
bug Something isn't working element templates
Milestone
M54

Comments

@christian-konrad
Copy link
Contributor

Describe the Bug

The element template name and icon are not displayed in the property panel header if the template is versioned (has a version attribute).

Steps to Reproduce

  1. Assign a template without a version attribute to a task of a C7 model
  2. ▶️ The icon and title are shown
  3. Add a version attribute to the template
  4. Refresh the modeler
  5. ▶️ The icon and title aren't displayed anymore

See screencast for reference:

Bildschirmaufnahme.2022-04-16.um.11.59.45.mov

Expected Behavior

The icon and name should be visible no matter if the template is versioned or not.

Environment

  • Camunda Modeler Version: 5.0.0
  • Execution Platform: C7.17
  • Installed plug-ins: None
@christian-konrad christian-konrad added bug Something isn't working element templates labels Apr 16, 2022
@pinussilvestrus
Copy link
Contributor

Icons are not implemented yet for Camunda Platform 7, that's probably why it doesn't properly work. However, the name should be displayed indeed.

@pinussilvestrus
Copy link
Contributor

I can reproduce it and move it to ready, as it is a bug in a recently added feature.

Something is broken in the header provider for versioned templates.

@pinussilvestrus pinussilvestrus added the ready Ready to be worked on label Apr 19, 2022
@pinussilvestrus pinussilvestrus self-assigned this Apr 19, 2022
pinussilvestrus pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 19, 2022
wip fix(render): use template version
6f3fecd 
Related to camunda/camunda-modeler#2920
pinussilvestrus pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 19, 2022
fix(render): use template version
fcf1437 
Related to camunda/camunda-modeler#2920
pinussilvestrus pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 19, 2022
fix(render): use template version
e815083 
Related to camunda/camunda-modeler#2920
@pinussilvestrus pinussilvestrus mentioned this issue Apr 19, 2022
Merged
@pinussilvestrus pinussilvestrus added needs review Review pending and removed ready Ready to be worked on labels Apr 19, 2022
@pinussilvestrus
Copy link
Contributor

This will be fixed upstream via bpmn-io/bpmn-js-properties-panel#670

pinussilvestrus pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 22, 2022
fix(render): use template version
c1199e4 
Related to camunda/camunda-modeler#2920
pinussilvestrus pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 22, 2022
fix(render): use template version
2fc49b9 
Related to camunda/camunda-modeler#2920
fake-join bot pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Apr 22, 2022
@fake-join
fix(render): use template version
1e5c414 
Related to camunda/camunda-modeler#2920
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Apr 22, 2022
@MaxTru MaxTru added this to the M54 milestone May 31, 2022
Skaiir added a commit that referenced this issue Jul 8, 2022
@Skaiir
deps: bump camunda-bpmn-js to 0.15.0
e77fc5d 
transitive deps:

`bpmn-js-properties-panel@0.15.1`
Closes #2989, #3003, #2725, #2920

`properties-panel@0.15.0`
Closes #2990

`bpmn-js@9.3.1`
Closes #2993
@Skaiir
Copy link
Contributor

Skaiir commented Jul 8, 2022 •
edited
Loading

Closed via bc8b748

@Skaiir Skaiir closed this as completed Jul 8, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jul 8, 2022
Skaiir added a commit that referenced this issue Jul 8, 2022
@Skaiir
deps: bump camunda-bpmn-js to 0.15.0
bc8b748 
transitive deps:

`bpmn-js-properties-panel@0.15.1`
Closes #2989, #3003, #2725, #2920

`properties-panel@0.15.0`
Closes #2990

`bpmn-js@9.3.1`
Closes #2993, #2859
@Skaiir Skaiir mentioned this issue Jul 8, 2022
Closed
40 tasks
marstamm pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jun 8, 2023
@fake-join
fix(render): use template version
3ad0e99 
Related to camunda/camunda-modeler#2920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working element templates
Projects
None yet
Milestone
M54
Development

No branches or pull requests
4 participants
@pinussilvestrus @Skaiir @MaxTru @christian-konrad