Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timer cycle definition to support cron expression #3061

Closed
korthout opened this issue Aug 3, 2022 · 14 comments · Fixed by #3184
Closed

Update timer cycle definition to support cron expression #3061

korthout opened this issue Aug 3, 2022 · 14 comments · Fixed by #3184
Assignees
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request properties panel spring cleaning Could be cleaned up one day
Milestone

Comments

@korthout
Copy link
Member

korthout commented Aug 3, 2022

What should we do?

Update timer cycle definition to support cron expressions.

Inspiration can be retrieved from the docs (once those are completed).

Why should we do it?

Camunda Platform 8.1 introduces the following

Note that we can define a CRON expression, but that the description specifies the ISO 8601 repeating intervals only:
Screen Shot 2022-08-03 at 16 00 40


Related to https://github.com/camunda/product-hub/issues/300.

@pinussilvestrus pinussilvestrus added ready Ready to be worked on Camunda 8 Flags an issue as related to Camunda 8 labels Aug 3, 2022
@pinussilvestrus
Copy link
Contributor

Are there changes needed for the property itself, or are only documentation/description updates required?

@korthout
Copy link
Member Author

korthout commented Aug 5, 2022

@pinussilvestrus I don't think so. For the Cycle Type, the Value can simply be set to a cron expression (like in the example above).

@nikku nikku added the enhancement New feature or request label Aug 9, 2022
@CatalinaMoisuc
Copy link
Member

We decided to split it up:

  • adapt the hint to highlight that you can use both CRON and ISO
  • support both and validate both versions

@nikku mentioned that he can pick up the first part.

@nikku
Copy link
Member

nikku commented Aug 9, 2022

Split up validation into separate topic: #3084. That one goes beyond duration but shall cover different mentions of times, durations and intervals, as well as CRON expressions across our app(s).

@nikku nikku removed their assignment Aug 19, 2022
@CatalinaMoisuc CatalinaMoisuc added this to the M56 milestone Aug 23, 2022
@CatalinaMoisuc
Copy link
Member

@barmac
As discussed, it makes sense to amend also the documentation with cron, even if the link is available for both 8.0 and 8.1.
This is the usual approach we use and we use linting to encourage the user to upgrade.

@CatalinaMoisuc
Copy link
Member

@barmac
No urgency, but when you start working on this could you please also move the Product Hub epic in Implement and write an update that we are on it? Thanks

@pinussilvestrus pinussilvestrus modified the milestones: M56, M57 Sep 6, 2022
@barmac
Copy link
Contributor

barmac commented Sep 15, 2022

Do we want to update the description for C7 too? As noted in the Zeebe issue, C7 also supports cron expression and it's documented: https://docs.camunda.org/manual/7.17/reference/bpmn20/events/timer-events/#time-cycle

@nikku
Copy link
Member

nikku commented Sep 15, 2022

Yes, let us do it!

@barmac
Copy link
Contributor

barmac commented Sep 20, 2022

Draft:

image

@barmac
Copy link
Contributor

barmac commented Sep 20, 2022

@barmac barmac added the in progress Currently worked on label Sep 20, 2022 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Sep 20, 2022
@christian-konrad
Copy link
Contributor

This looks fine! I assume this is parsed at Zeebe, and no additional flag necessary to pass so Zeebe knows what to expect?

@barmac
Copy link
Contributor

barmac commented Sep 20, 2022

I confirmed that a timer with exactly this expression is successfully deployed to zeebe@8.1.0-alpha5. No additional flags are required.

@barmac
Copy link
Contributor

barmac commented Sep 20, 2022

OK, so I will proceed with the contents as on the screenshot.

barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Sep 21, 2022
barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Sep 21, 2022
@barmac
Copy link
Contributor

barmac commented Sep 21, 2022

This will be implemented via bpmn-io/bpmn-js-properties-panel#772

barmac added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Sep 22, 2022
@barmac barmac added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Sep 27, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Sep 29, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 29, 2022
marstamm pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Camunda 8 Flags an issue as related to Camunda 8 enhancement New feature or request properties panel spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants