Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay does not open up the properties panel on single click #3127

Closed
GeethaParthasarathy opened this issue Sep 9, 2022 · 1 comment · Fixed by #3131
Closed

Error overlay does not open up the properties panel on single click #3127

GeethaParthasarathy opened this issue Sep 9, 2022 · 1 comment · Fixed by #3131
Assignees
Labels
bug Something isn't working

Comments

@GeethaParthasarathy
Copy link

Describe the bug

When we try to click on the error overlay and open up the properties panel it is not possible with a single click rather we need to click twice to achieve the output.

Steps to reproduce

  1. Create a BPMN diagram with Camunda Platform 8
  2. Create any two tasks that would produce lint error
  3. Now try to traverse between the lint error overlay of the tasks we could see sometimes on a single click the properties panel is open and the respective error is highlighted while sometimes it needs a double click on the overlay.
9caf7810f433d8cc72f3d97f53b0b312.mp4

Expected behavior

On clicking the error overlay once the properties panel should be open

Environment

  • OS: [ Windows 10]
  • Camunda Modeler Version: [5.3.0]
  • Execution Platform: [ Camunda Cloud]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Sep 9, 2022
@philippfromme
Copy link
Contributor

I spent some time looking into this issue. I cannot reproduce it in https://github.com/philippfromme/linting-playground. The issue occurs only when clicking an overlay focuses a text input in the properties panel. The next click after that doesn't do anything for some reason. I'll need more time to look into this.

@pinussilvestrus pinussilvestrus added the ready Ready to be worked on label Sep 12, 2022 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 12, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on in progress Currently worked on labels Sep 12, 2022
philippfromme added a commit that referenced this issue Sep 19, 2022
* rename #onToggleLinting to #handleToggleLinting

Closes #3127
philippfromme added a commit that referenced this issue Sep 19, 2022
* rename #onToggleLinting to #handleToggleLinting

Closes #3127
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 20, 2022
barmac pushed a commit to camunda/linting that referenced this issue Sep 23, 2022
* fix: use setTimeout to work around properties panel focus issue

Related to camunda/camunda-modeler#3127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants