-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict number formats in fields "decimal" and "increment" for a number form element #3382
Comments
Regarding the increment, this is something I've overlooked but I have a fix ready in the next version of form-js. Regarding decimal digits, it's more of a limitation/slight bug of the number field in the properties panel. This can be replicated with any other simple number field. May be worth raising within the properties panel. |
Partially fixed upstream via bpmn-io/form-js#490. We now trim the increment value to strip it of prefixed zeros. Regarding the |
Fully fixed upstream via bpmn-io/form-js#531 |
@Skaiir I added the HTO iteration 16 milestone to bpmn-io/form-js#531 so we do not swallow our calculation and the Desktop Modeler team can modify the milestone on this issue 👍 |
Closed via #3422. |
Describe the bug
When we choose a number form element we could see that there are options in the properties panel to restrict the number of decimal places and increment the value of the number.
For restricting the number of decimal places we could enter a decimal number but does not really make sense to restrict the digits using a decimal number
Also in case of increments when we enter "0 "as an increment error is thrown but when we add any other number next to it we could see that the enter number is taken into account along with the 0 entered before say 05.
"0" before the number should not be accepted as it leads to confusion
Steps to reproduce
decimal digits -> 5.123
Increment->0005
Expected behavior
To avoid ambiguity to users the above fields must be restricted to valid number formats
Environment
Additional context
No response
The text was updated successfully, but these errors were encountered: