Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved is not indicated on new diagrams #3620

Closed
nikku opened this issue May 17, 2023 · 0 comments · Fixed by #3621
Closed

Unsaved is not indicated on new diagrams #3620

nikku opened this issue May 17, 2023 · 0 comments · Fixed by #3621
Assignees
@nikku
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Milestone
M65

Comments

@nikku
Copy link
Member

nikku commented May 17, 2023

Describe the bug

When creating a new diagram I need to edit it at least once before it is marked as unsaved in the UI. It is properly marked as unsaved in the hover tooltip:

capture hsARSD_optimized

Steps to reproduce

  1. Create new diagram
  2. See no unsaved marker
  3. Change diagram contents
  4. See unsaved marker appear

Expected behavior

New diagrams are marked as unsaved until they are saved for the first time.

Environment

  • OS: Linux
  • Camunda Modeler Version: v5.11
  • Execution Platform: Any
  • Installed plug-ins: None

Additional context

No response
@nikku nikku added bug Something isn't working spring cleaning Could be cleaned up one day labels May 17, 2023
nikku added a commit that referenced this issue May 17, 2023
@nikku
chore: centralize isDirty handling of tabs
fb5002e 
Closes #3620
@nikku nikku mentioned this issue May 17, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 17, 2023
nikku added a commit that referenced this issue May 17, 2023
@nikku
chore: centralize isDirty handling of tabs
0b1b855 
Closes #3620
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 17, 2023
@nikku nikku added this to the M65 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
M65
Development

Successfully merging a pull request may close this issue.

Consistently show unsaved indicator in tabs camunda/camunda-modeler
1 participant
@nikku