Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure diagram is exported after namespace change #403

Closed
ricardomatias opened this issue Aug 22, 2016 · 1 comment
Closed

Make sure diagram is exported after namespace change #403

ricardomatias opened this issue Aug 22, 2016 · 1 comment
Assignees
@barmac
Labels
BPMN channel:support enhancement New feature or request
Milestone
M27

Comments

@ricardomatias
Copy link
Contributor

ricardomatias commented Aug 22, 2016 •
edited by nikku

When a activiti diagram is migrated to the camunda namespace, we're not exporting the file, unless the diagram is changed manually.

We should make sure the file is marked as dirty after the conversion so that it gets properly exported through saveXML (potentially updating attributes and other things with the conversion).

See SUPPORT-2599.
@ricardomatias ricardomatias added this to the Backlog milestone Aug 22, 2016
nikku added a commit that referenced this issue Aug 22, 2016
@nikku
test(client): add DI to namespace conversion test diagram
a1e6cb3 
Related to #403
@nikku nikku self-assigned this Aug 22, 2016
@nikku nikku added in progress Currently worked on and removed in progress Currently worked on labels Aug 22, 2016
@nikku nikku removed their assignment Aug 22, 2016
@nikku nikku added enhancement New feature or request and removed feature labels Oct 4, 2016
@nikku nikku added the backlog Queued in backlog label Feb 14, 2018
@nikku nikku removed this from the Backlog milestone Feb 14, 2018
@barmac barmac mentioned this issue Jan 22, 2019
Closed
barmac added a commit that referenced this issue Jan 23, 2019
@barmac
fix(client/BpmnEditor): mark tab as dirty after namespace conversion
0a4751c 
Closes #1122
Closes #403
@barmac barmac mentioned this issue Jan 23, 2019
Merged
@ghost ghost assigned barmac Jan 23, 2019
@ghost ghost added needs review Review pending and removed backlog Queued in backlog labels Jan 23, 2019
merge-me bot pushed a commit that referenced this issue Jan 23, 2019
@barmac @merge-me
fix(client/BpmnEditor): mark tab as dirty after namespace conversion
253d98c 
Closes #1122
Closes #403
@nikku nikku added this to the M27 milestone Jan 23, 2019
@nikku
Copy link
Member

nikku commented Jan 23, 2019

Closed via #1133.

@nikku nikku closed this as completed Jan 23, 2019
@ghost ghost removed the needs review Review pending label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
BPMN channel:support enhancement New feature or request
Projects
None yet
Milestone
M27
Development

No branches or pull requests
3 participants
@nikku @ricardomatias @barmac