Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build application locally on MacOS (spawnSync zip ENOENT) #4236

Closed
barmac opened this issue Apr 11, 2024 · 7 comments · Fixed by #4238
Closed

Cannot build application locally on MacOS (spawnSync zip ENOENT) #4236

barmac opened this issue Apr 11, 2024 · 7 comments · Fixed by #4238
Assignees
Labels
bug Something isn't working platform:Darwin
Milestone

Comments

@barmac
Copy link
Contributor

barmac commented Apr 11, 2024

Describe the bug

I cannot build the application locally due to an error: ⨯ spawnSync zip ENOENT failedTask=build stackTrace=Error: spawnSync zip ENOENT.

Steps to reproduce

  1. Be on Mac
  2. Run npm run build
  3. now this happens

Expected behavior

It should work.

Environment

  • OS: MacOS Sonoma 14.4
  • Camunda Modeler Version: [e.g. 2.0.0]
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

Discovered by @jwulf

Related to #1996

@barmac barmac added the bug Something isn't working label Apr 11, 2024
@barmac barmac self-assigned this Apr 11, 2024
@barmac barmac added the ready Ready to be worked on label Apr 11, 2024
@jwulf
Copy link
Member

jwulf commented Apr 11, 2024

Additional context:

jwulf@Joshs-MacBook-Pro camunda-modeler % which zip
/usr/bin/zip

@barmac
Copy link
Contributor Author

barmac commented Apr 11, 2024

This seems to be related to electron-userland/electron-builder#6821

@barmac
Copy link
Contributor Author

barmac commented Apr 11, 2024

OK this is actually easier than I thought. In the ZIP step, we use a wrong directory name:

image

Notice that we use /dist/mac while only /dist/mac-arm64 exists.

@nikku
Copy link
Member

nikku commented Apr 11, 2024

@barmac As we're on it, shall we start to create different distributions for ARM vs. intel?

@barmac
Copy link
Contributor Author

barmac commented Apr 11, 2024

You're reading my mind.

@barmac
Copy link
Contributor Author

barmac commented Apr 11, 2024

With updated file name, it builds correctly on Mac. I will now try out building for both ARM and x86.

@barmac
Copy link
Contributor Author

barmac commented Apr 11, 2024

I was able to build for ARM64 and I gotta tell you the Modeler opens super quickly. It's a major improvement. Expect a PR today.

barmac added a commit that referenced this issue Apr 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Apr 11, 2024
@nikku nikku added this to the M76 milestone Apr 11, 2024
@barmac barmac closed this as completed in 2f285e2 Apr 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:Darwin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants