Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When importing an empty BPMN file I get asked if I want to create a new diagram #636

Closed
philippfromme opened this issue Aug 2, 2017 · 1 comment
Closed

When importing an empty BPMN file I get asked if I want to create a new diagram #636

philippfromme opened this issue Aug 2, 2017 · 1 comment
Assignees
@nikku
Labels
BPMN channel:support enhancement New feature or request
Milestone
M21

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Aug 2, 2017 •
edited
Loading

Importing an empty BPMN file results in an exception which is technically correct but not nice. When importing an empty file the user should get asked through a dialog if he wants to create a new process.

Confluence Ticket: https://app.camunda.com/jira/servicedesk/agent/SUPPORT/queues/7/SUPPORT-3540
@philippfromme philippfromme changed the title When importing an empty .bpmn I get asked if I want to create a new diagram When importing an empty BPMN file I get asked if I want to create a new diagram Aug 2, 2017
@philippfromme philippfromme added this to the Camunda BPM 7.8 milestone Aug 8, 2017
@philippfromme philippfromme modified the milestones: M15, Camunda BPM 7.8 Aug 29, 2017
@nikku nikku modified the milestones: M15, M16 Oct 27, 2017
@nikku nikku modified the milestones: M16, M20 Jan 25, 2018
@romansmirnov romansmirnov modified the milestones: M20, M21 Apr 3, 2018
@nikku nikku added backlog Queued in backlog BPMN enhancement New feature or request labels Apr 9, 2018
@philippfromme philippfromme self-assigned this Apr 10, 2018
@ghost ghost added in progress Currently worked on and removed backlog Queued in backlog labels Apr 11, 2018
philippfromme added a commit that referenced this issue Apr 16, 2018
@philippfromme
feat(app): create new diagram when opening empty file
2037bc6 
Closes #636
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Apr 16, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Apr 16, 2018
philippfromme added a commit that referenced this issue Apr 16, 2018
@philippfromme
feat(app): create new diagram when opening empty file
22bc8db 
Closes #636
nikku pushed a commit that referenced this issue Apr 17, 2018
@philippfromme @nikku
feat(app): create new diagram when opening empty file
f111a67 
Closes #636
nikku pushed a commit that referenced this issue Apr 17, 2018
@philippfromme @nikku
feat(app): create new diagram when opening empty file
936c097 
Closes #636
@nikku
Copy link
Member

nikku commented Apr 17, 2018

Review Hints

  • Add an end-to-end test that verifies the dialog integration on file open (cf. this test for a blueprint

@nikku nikku added ready Ready to be worked on and removed needs review Review pending labels Apr 17, 2018
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
020b9f4 
Closes #636
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
6f81450 
Closes #636
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
4c4a7d5 
Closes #636
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
44661bb 
Closes #636
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
a61e987 
Closes #636
philippfromme added a commit that referenced this issue Apr 18, 2018
@philippfromme
feat(app): create new diagram when opening empty file
ff1dc54 
Closes #636
@nikku nikku closed this as completed in 4c44b61 Apr 18, 2018
@ghost ghost removed the ready Ready to be worked on label Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
BPMN channel:support enhancement New feature or request
Projects
None yet
Milestone
M21
Development

No branches or pull requests
4 participants
@nikku @romansmirnov @mburke84 @philippfromme