Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive default deployment name from the filename #1511

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Derive default deployment name from the filename #1511

merged 1 commit into from
Oct 4, 2019

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Sep 24, 2019 •
edited
Loading

This PR allows to derive the deployment name from the filename. E.g. for a file called diagram_1.bpmn it will set the deployment name to diagram_1.

Requires #1491

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 24, 2019
@barmac barmac force-pushed the derive-diagram-name-from-file-name branch from f9153e1 to 7c7ad4e Compare September 26, 2019 09:34
@barmac barmac force-pushed the derive-diagram-name-from-file-name branch from 7c7ad4e to 77829e5 Compare September 30, 2019 12:25
@barmac barmac changed the base branch from deployment-tool-as-a-plugin to develop September 30, 2019 12:25
@barmac barmac changed the title feat(deploy): derive default deployment name from the filename Derive default deployment name from the filename Sep 30, 2019
@barmac barmac force-pushed the derive-diagram-name-from-file-name branch 5 times, most recently from 49100f8 to 635f4c4 Compare October 2, 2019 08:57
@philippfromme philippfromme force-pushed the derive-diagram-name-from-file-name branch from 635f4c4 to a5a272f Compare October 4, 2019 09:21
philippfromme
philippfromme approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@merge-me merge-me bot merged commit b162ec2 into develop Oct 4, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the derive-diagram-name-from-file-name branch October 4, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barmac @philippfromme