-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement concept for modal windows #1686
Conversation
Umm I missed the close icon hover/active style. Let me fix that. |
* Header, body and footer are now visibly separated. * Modal keeps responsiveness for smaller screens. * In case of content being higher than maximum height, modal body is scrollable. Closes #1681
f403f7b
to
eb0cefa
Compare
@nikku @nazlikaya Ready for review |
Looks good from the feel perspective. |
Added two minor fixes on top. |
Looking goood! 👍 |
Noticed: missing X button for some modals |
This is by design. The user may not close the dialog via ESC or close button. Instead, she has to explicitly confirm what is written there (provide consent). |
Exactly. |
Enter needs to trigger the Primary button, only if the primary button is on focus. Other than that 👍 |
That's how it works right now, right? |
I added |
🍰 |
Summary of changes:
modal body is scrollable.
Closes #1681
Closes #1575