Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace menu shortcut #3364

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Add replace menu shortcut #3364

merged 3 commits into from
Jan 2, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Dec 15, 2022 •
edited
Loading

Depends on camunda/camunda-bpmn-js#216 (needs the lastest version) ✅

The 'r'/'R' shortcut works for replace when an element is selected, and maintains the token simulation behaviour when no element is selected - there is no interference here and so I didn't see a reason to do extra changes here now.

Closes #3332

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 15, 2022
@smbea smbea marked this pull request as draft December 15, 2022 10:37
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Dec 15, 2022
@smbea smbea linked an issue Dec 15, 2022 that may be closed by this pull request
Integrate new replace menu #3332
Closed
2 tasks
@smbea smbea force-pushed the 3332-integrate-new-replace branch from b8c07fe to c5533ed Compare January 2, 2023 11:15
@smbea smbea marked this pull request as ready for review January 2, 2023 12:31
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 2, 2023
@smbea smbea requested review from a team, philippfromme, barmac and marstamm and removed request for a team and barmac January 2, 2023 12:33
@smbea
Copy link
Contributor Author

smbea commented Jan 2, 2023

@marstamm @philippfromme can anyone have a look? would love to get this in before the code freeze

@marstamm
Copy link
Member

marstamm commented Jan 2, 2023

I'll have a look

marstamm
marstamm reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good overall, I found some smaller improvements we can consider before merging

client/src/app/tabs/getEditMenu.js Outdated Show resolved Hide resolved
client/src/app/tabs/getEditMenu.js Show resolved Hide resolved
@smbea smbea force-pushed the 3332-integrate-new-replace branch from c5533ed to 4163d6b Compare January 2, 2023 15:24
marstamm
marstamm approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up! Works great now

@smbea smbea merged commit 95a0c8b into develop Jan 2, 2023
@smbea smbea deleted the 3332-integrate-new-replace branch January 2, 2023 15:36
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 2, 2023
@smbea smbea mentioned this pull request Jan 2, 2023
Open
2 tasks
@philippfromme philippfromme mentioned this pull request Jan 5, 2023
Closed
41 tasks
@nikku nikku added this to the M60 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from camunda/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
M60
Development

Successfully merging this pull request may close these issues.

Integrate new replace menu
3 participants
@smbea @marstamm @nikku