Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Camunda Modeler 5.7 Release #3376

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Prepare Camunda Modeler 5.7 Release #3376

merged 5 commits into from
Jan 4, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jan 4, 2023 •
edited
Loading

  • update modeling dependencies
  • update @codemirror dependencies
  • update CHANGELOG
  • update release info

electron_Azkl2p2Cfh

Related to #3361

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 4, 2023
@philippfromme philippfromme force-pushed the 5-7-release branch 2 times, most recently from 38e35aa to 8cdc43c Compare January 4, 2023 10:40
@philippfromme philippfromme force-pushed the 5-7-release branch 2 times, most recently from 3619d1f to 5c1406c Compare January 4, 2023 12:41
@philippfromme philippfromme marked this pull request as ready for review January 4, 2023 12:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 4, 2023
smbea
smbea suggested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only is "unlink template from replace menu" new but the "replace with template" is also new in camunda modeler (also done in camunda/camunda-bpmn-js#219) since it was hidden behind a feature flag before. So we can add this to the CHANGELOG and release info maybe.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jan 4, 2023
marstamm
marstamm reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, I added some small grammar/punctuation suggestions

client/src/plugins/version-info/ReleaseInfo.js Outdated Show resolved Hide resolved
client/src/plugins/version-info/ReleaseInfo.js Outdated Show resolved Hide resolved
client/src/plugins/version-info/ReleaseInfo.js Outdated Show resolved Hide resolved
@philippfromme
Copy link
Contributor Author

philippfromme commented Jan 4, 2023 •
edited
Loading

but the "replace with template" is also new in camunda modeler

Oh, wow. I missed that! So the whole "work with templates through the replace menu" is new! Cool, I will include it!

smbea
smbea approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just left a small comment which you may ignore if it doesn't make sense

client/src/plugins/version-info/ReleaseInfo.js Outdated
<h4>New replace menu UI in the BPMN editor</h4>
Easily find the replacement element you are looking for with the search feature in the menu.
<h4>Element templates accessible through replace menu</h4>
Apply an element template directly through the replace menu without having to change the element type first. Unlink an element template simply by replacing the element. With an element selected, press <kbd>R</kbd> to open the replace menu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also keep it simple here about the templates like "Apply and unlink element templates directly through the replace menu." But it's also ok with how it is, I'm not sure how we usually do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I adjusted it.

@philippfromme philippfromme merged commit 9549df7 into develop Jan 4, 2023
@philippfromme philippfromme deleted the 5-7-release branch January 4, 2023 14:38
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Jan 4, 2023
@nikku nikku added this to the M60 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbea smbea smbea approved these changes

@marstamm marstamm Awaiting requested review from marstamm

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
M60
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philippfromme @marstamm @smbea @nikku