New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can add BPMN moddle extensions as plugins #949

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Ichigo85
Contributor

Ichigo85 commented Oct 16, 2018

This pull request can close issue #669 .
I already explained everything in this forum topic.

@wafflebot wafflebot bot added the needs review label Oct 16, 2018

@nikku nikku self-requested a review Oct 25, 2018

Show resolved Hide resolved client/lib/app/editor/bpmn-editor.js Outdated

@nikku nikku removed the needs review label Oct 26, 2018

@nikku

This comment has been minimized.

Member

nikku commented Oct 27, 2018

@philippfromme Could you take this one over?

@philippfromme

This comment has been minimized.

Contributor

philippfromme commented Oct 29, 2018

@nikku Will take care of this.

@philippfromme

This comment has been minimized.

Contributor

philippfromme commented Oct 29, 2018

In order to complete this story we need to add a helper function to https://github.com/camunda/camunda-modeler-plugin-helpers.

function registerBpmnJSModdleExtension(plugin) {
  registerClientPlugin(plugin, 'bpmn.modeler.moddleExtension');
}

@philippfromme philippfromme changed the title from Possibility to add additional moddles on bpmn-editor to I can add BPMN moddle extensions as plugins Oct 29, 2018

@philippfromme

This comment has been minimized.

Contributor

philippfromme commented Oct 29, 2018

Merged through b141254.

philippfromme added a commit to camunda/camunda-modeler-plugin-helpers that referenced this pull request Nov 2, 2018

philippfromme added a commit to camunda/camunda-modeler-plugin-helpers that referenced this pull request Nov 26, 2018

nikku added a commit to camunda/camunda-modeler-plugin-helpers that referenced this pull request Nov 26, 2018

philippfromme added a commit to camunda/camunda-modeler-plugin-helpers that referenced this pull request Nov 26, 2018

philippfromme added a commit to camunda/camunda-modeler-plugin-helpers that referenced this pull request Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment