Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade keycloak chart from 16.1.7 to 17.3.5 #1143

Merged
merged 1 commit into from
Dec 14, 2023
Merged

refactor: upgrade keycloak chart from 16.1.7 to 17.3.5 #1143

merged 1 commit into from
Dec 14, 2023

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

What's in this PR?

Issue: #1102

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hamza-m-masood hamza-m-masood linked an issue Dec 12, 2023 that may be closed by this pull request
[TASK] Update Keycloak chart major version #1102
Closed
1 task
@github-actions github-actions bot temporarily deployed to gke-1143 December 12, 2023 18:59 Destroyed
@github-actions github-actions bot temporarily deployed to gke-1143-upgrade December 12, 2023 18:59 Destroyed
@hamza-m-masood hamza-m-masood added the size/xs Relative effort/time: Extra Small label Dec 12, 2023
@github-actions github-actions bot temporarily deployed to rosa-1143 December 12, 2023 18:59 Destroyed
@hamza-m-masood hamza-m-masood self-assigned this Dec 12, 2023
@hamza-m-masood hamza-m-masood force-pushed the 1102-task-update-keycloak-chart-major-version branch from ff6ba5f to 00acd1d Compare December 12, 2023 19:05
@github-actions github-actions bot temporarily deployed to gke-1143-upgrade December 12, 2023 19:07 Destroyed
@github-actions github-actions bot temporarily deployed to gke-1143 December 12, 2023 19:07 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-1143 December 12, 2023 19:07 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-1143-upgrade December 12, 2023 19:07 Destroyed
@hamza-m-masood hamza-m-masood marked this pull request as ready for review December 13, 2023 10:46
@hamza-m-masood hamza-m-masood requested a review from a team December 13, 2023 10:46
@jessesimpson36 jessesimpson36 added the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Dec 13, 2023
@github-actions github-actions bot temporarily deployed to gke-1143 December 13, 2023 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-1143-upgrade December 13, 2023 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to gke-1143-upgrade December 13, 2023 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-1143 December 13, 2023 13:15 Destroyed
@jessesimpson36 jessesimpson36 removed the test-persistent Don't delete the Helm deployment created by the PR and use fixed names label Dec 13, 2023
@aabouzaid aabouzaid requested review from aabouzaid and removed request for a team December 14, 2023 18:35
@aabouzaid aabouzaid changed the title Update Keycloak chart major version refactor: upgrade keycloak chart from 16.1.7 to 17.3.5 Dec 14, 2023
aabouzaid
aabouzaid approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit d1f6234 into main Dec 14, 2023
14 checks passed
@aabouzaid aabouzaid deleted the 1102-task-update-keycloak-chart-major-version branch December 14, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@hamza-m-masood hamza-m-masood

Labels
kind/task size/xs Relative effort/time: Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Update Keycloak chart major version
3 participants
@hamza-m-masood @aabouzaid @jessesimpson36