Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC]: Add Optimize Helm chart #126

Closed
19 tasks done
Zelldon opened this issue Jan 24, 2022 · 2 comments
Closed
19 tasks done

[EPIC]: Add Optimize Helm chart #126

Zelldon opened this issue Jan 24, 2022 · 2 comments
Assignees
Labels

Comments

@Zelldon
Copy link
Member

Zelldon commented Jan 24, 2022

Add optimize chart to the single chart.

Depends on #127

@Zelldon
Copy link
Member Author

Zelldon commented Apr 21, 2022

For visibility, I raised the following in slack:

⚠️ Request for feedback/input

I'm working on the Optimize integration and found some things I would like to discuss.

  • Optimize needs to be configured with the partition count. Currently, this information is located in the Zeebe sub-chart. Helm doesn't allow sharing of information between child /sub-charts. The following solutions I see:
    • We add a new property, which is globally available. Like: global.zeebePartitionCount The problem I see here is that currently, we have zeebe.partitionCount which people use. We could drop the property and print a warning if this property is still in use. If we want to keep the value: we could use the value of global.zeebePartitionCount in zeebe.partitionCount, to only configure one property. But this will not help with users which already use zeebe.partitionCount and are not aware of the new property.
    • We add just a new property in the Optimize sub chart and the user needs to configure the partition count in two places. In zeebe and optimize section.
    • I could investigate an idea I had recently. In the root we have access to all properties, so we might be able to deploy a config map for Optimize, which contains the properties from Zeebe.
    • Optimize can somehow self-detect the partition count like operate does
  • Optimize has a dependency on identity. What if identity is disabled? Should we disable Optimize as well? Might make sense to me.
  • We currently have identity.enabled to enable and deploy identity resources and global.identity.auth.enable to enable the authentication for all web apps with identity. Currently you have to disable both to run operate or tasklist without identity (and not deploy identity resources). Do we want to combine them? Like only having global.identity.auth.enable and removing identity.enabled . This would be a breaking change, but I don't expect too many problems with that.

@Zelldon
Copy link
Member Author

Zelldon commented Apr 27, 2022

@Zelldon Zelldon closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants