Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add Ingress details into NOTES.txt #736

Closed
aabouzaid opened this issue Jun 8, 2023 · 3 comments
Closed

[ENHANCEMENT] Add Ingress details into NOTES.txt #736

aabouzaid opened this issue Jun 8, 2023 · 3 comments
Labels
good first issue Good for newcomers kind/enhancement New feature or request size/xs Relative effort/time: Extra Small

Comments

@aabouzaid
Copy link
Member

aabouzaid commented Jun 8, 2023 •
edited

Describe the enhancement/feature:

Currently, we don't have the Ingress details in NOTES.txt. It would be helpful to have the URLs for combined and separated Ingress setup.

Desired outcome and acceptance tests:

  • Conditionally add Ingress URLs into NOTES.txt for combined and separated Ingress setup.

Fixed by: #749
@aabouzaid aabouzaid added kind/enhancement New feature or request good first issue Good for newcomers size/xs Relative effort/time: Extra Small labels Jun 8, 2023
@aabouzaid aabouzaid mentioned this issue Jun 12, 2023
Closed
1 task
@mustafaelghrib
Copy link
Contributor

@aabouzaid where to find those Ingress URLs?

@aabouzaid
Copy link
Member Author

@mstva in the values file under global.ingress.host in case of the combined Ingress setup.

or under [APP_NAME].ingress.host in case of the separated Ingress setup.

@mustafaelghrib mustafaelghrib mentioned this issue Jun 14, 2023
Merged
7 tasks
@aabouzaid
Copy link
Member Author

This was fixed by: #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement New feature or request size/xs Relative effort/time: Extra Small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aabouzaid @mustafaelghrib