Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Translation #11

Closed
wants to merge 1 commit into from
Closed

Japanese Translation #11

wants to merge 1 commit into from

Conversation

mas178
Copy link
Contributor

@mas178 mas178 commented May 28, 2016

It's my first pr, please let me know if there are any problems.

@shentschel shentschel self-assigned this May 30, 2016
@shentschel
Copy link

Hi Masaaki,

this pull reuqest looks good. 👍 I only have a question regarding some items which are not or only partly translated.

The Keys of the items are:

  • CURRENT_GROUPS
  • ACTION
  • RESTRICTION_NOTICE
  • TASK_LIST_LOADING_FAILURE

Have you missed them or is there no translation for these items?

Cheers

Stefan :)

@mas178
Copy link
Contributor Author

mas178 commented May 30, 2016

Hi Stefan,

Thank you for your review. They are mistakes and fixed them.

Masaaki

@shentschel
Copy link

Hi Masaaki,

yesterday @SebastianStamm added a new field to the english translation. Maybe you want to translate it with this pull request too. The Item is:

  • "NEW_TASK_TENANT_ID": "Tenant Id"

If you do this, the translation would be completely in sync with our current english translation.

Cheers,

Stefan :)

Modify leakage

Add NEW_TASK_TENANT_ID
@mas178
Copy link
Contributor Author

mas178 commented May 31, 2016

I added NEW_TASK_TENANT_ID.
BTW the new multi-tenancy function is very cool! 👍

@shentschel
Copy link

Hi Masaaki,

I merged your pull request :)

どうもありがとうございました 👍

Cheers,

Stefan

@shentschel shentschel closed this May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants