refactoring(engine): align rejection message

camunda · Jan 27, 2022 · aacca62 · aacca62
1 parent 0629de0
commit aacca62
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.../java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java b/.../java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java
@@ -102,8 +102,8 @@ public Either<Failure, Void> transformResource(
             duplicatedDrg -> {
               final var failureMessage =
                   String.format(
-                      "The decision requirements ids must be unique within a deployment."
-                          + " Found a duplicated id '%s' in the resources '%s' and '%s'.",
+                      "Expected the decision requirements ids to be unique within a deployment"
+                          + " but found a duplicated id '%s' in the resources '%s' and '%s'.",
                       decisionRequirementsId,
                       duplicatedDrg.getResourceName(),
                       resource.getResourceName());
@@ -127,8 +127,8 @@ public Either<Failure, Void> transformResource(
             duplicatedDecision -> {
               final var failureMessage =
                   String.format(
-                      "The decision ids must be unique within a deployment."
-                          + " Found a duplicated id '%s' in the resources '%s' and '%s'.",
+                      "Expected the decision ids to be unique within a deployment"
+                          + " but found a duplicated id '%s' in the resources '%s' and '%s'.",
                       duplicatedDecision.getDecisionId(),
                       findResourceName(
                           deploymentEvent, duplicatedDecision.getDecisionRequirementsKey()),

diff --git a/engine/src/test/java/io/camunda/zeebe/engine/processing/deployment/DeploymentDmnTest.java b/engine/src/test/java/io/camunda/zeebe/engine/processing/deployment/DeploymentDmnTest.java
@@ -393,8 +393,8 @@ public void shouldRejectIfMultipleDrgHaveTheSameId() {
     assertThat(deploymentEvent.getRejectionReason())
         .contains(
             String.format(
-                "The decision requirements ids must be unique within a deployment. "
-                    + "Found a duplicated id 'force-users' in the resources '%s' and '%s'",
+                "Expected the decision requirements ids to be unique within a deployment "
+                    + "but found a duplicated id 'force-users' in the resources '%s' and '%s'",
                 DMN_DECISION_TABLE, DMN_DECISION_TABLE_V2));
   }
 
@@ -418,8 +418,8 @@ public void shouldRejectIfMultipleDecisionsHaveTheSameId() {
     assertThat(deploymentEvent.getRejectionReason())
         .contains(
             String.format(
-                "The decision ids must be unique within a deployment. "
-                    + "Found a duplicated id 'jedi-or-sith' in the resources '%s' and '%s'",
+                "Expected the decision ids to be unique within a deployment "
+                    + "but found a duplicated id 'jedi-or-sith' in the resources '%s' and '%s'",
                 DMN_DECISION_TABLE, DMN_DECISION_TABLE_RENAMED_DRG));
   }