Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete backup api in gateway #10209

Closed
5 tasks done
Tracked by #9606 ...
deepthidevaki opened this issue Aug 29, 2022 · 1 comment
Closed
5 tasks done
Tracked by #9606 ...

Implement delete backup api in gateway #10209

deepthidevaki opened this issue Aug 29, 2022 · 1 comment
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0-alpha3 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented Aug 29, 2022

  • Add openapi spec
  • BackupRequestHandler sends request to all partitions and aggregates responses
  • Implement the endpoint
  • Return 502 on connection errors
  • Add acceptance IT tests
@deepthidevaki deepthidevaki added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 29, 2022
@deepthidevaki deepthidevaki self-assigned this Oct 28, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Dec 2, 2022
11156: Add openapi spec for delete backup api r=deepthidevaki a=deepthidevaki

## Description

Define spec for delete backup api. The spec aligns with the api discussed [here](https://docs.google.com/document/d/1pITW-pvUiGuJ8kIeR1vqjnoqmhs0unnNN955jUkhF6w/edit#heading=h.8n6adu75g6g3)

## Related issues

related #10209 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 5, 2022
11157: Gateway can handle delete backup request r=deepthidevaki a=deepthidevaki

## Description

- BackupRequestHandler sends delete request to all partitions and collect the responses.
- Request is failed if request to atleast one partition fails.

Note:- Connection errors are differentiated from other errors which is expected according to spec. This will be updated along with other operations. 

## Related issues

related #10209 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 6, 2022
11184: Add delete backup endpoint r=deepthidevaki a=deepthidevaki

## Description

Add delete backup endpoint and tests. 
Note:- error response for connection errors is not added. It will be updated together with other apis.

## Related issues

related #10209 


Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 6, 2022
11184: Add delete backup endpoint r=deepthidevaki a=deepthidevaki

## Description

Add delete backup endpoint and tests. 
Note:- error response for connection errors is not added. It will be updated together with other apis.

## Related issues

related #10209 


Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 7, 2022
11192: Return specific error codes for backup request r=deepthidevaki a=deepthidevaki

## Description

Return specific error codes for connection issues and when backup is not enabled.

We had decided to use 502 for connection errors. But it also makes sense to use 504 to denote timeouts (See #11156 (comment)). We now use both to distinguish different cases. I have also updated the spec. Operate and Optimize would probably return 502 for all connection issues.

## Related issues

closes #10849 #10209 #11124 #10967 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@deepthidevaki
Copy link
Contributor Author

closed by #11192

@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.2.0-alpha3 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

No branches or pull requests

3 participants