Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for BackupManager #10386

Closed
Tracked by #9606
deepthidevaki opened this issue Sep 16, 2022 · 0 comments · Fixed by #10449
Closed
Tracked by #9606

Add metrics for BackupManager #10386

deepthidevaki opened this issue Sep 16, 2022 · 0 comments · Fixed by #10449
Assignees
@lenaschoenburg
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented Sep 16, 2022 •
edited
Loading

Possible metrics:

  • Number of in progress backups
  • Duration for taking a backup
@deepthidevaki deepthidevaki mentioned this issue Sep 16, 2022
Closed
58 tasks
@lenaschoenburg lenaschoenburg self-assigned this Sep 22, 2022
@lenaschoenburg lenaschoenburg mentioned this issue Sep 22, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Sep 22, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #10449
5e84fc0 
10449: feat(backup): collect metrics when for backup manager operations r=oleschoenburg a=oleschoenburg

closes #10386 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Sep 26, 2022
@zeebe-bors-camunda @deepthidevaki @lenaschoenburg
merge: #10443 #10449
1023992 
10443: Do not take a backup if it already exists r=deepthidevaki a=deepthidevaki

## Description

After restore, the log is truncated to the checkpoint position. So the checkpoint record is processed again and will trigger a new backup with the same Id of the backup it restored from. With this PR, `BackupService` handles this case gracefully. In addition, we also do not take a new backup if existing backup is failed or in progress. Alternatively, we can delete this backup and take a new one. But chances of it happening (i.e triggering a new backup when one already is in progress/failed) is very low. So we can keep this simple.

## Related issues

closes #10430 



10449: feat(backup): collect metrics when for backup manager operations r=oleschoenburg a=oleschoenburg

closes #10386 

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@lenaschoenburg lenaschoenburg mentioned this issue Sep 27, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Sep 27, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #10513
686875c 
10513: fix: backup manager metrics should be prefixed with 'backup' r=deepthidevaki a=oleschoenburg

I didn't use the 'backup' in the name of metrics introduced for #10386, this PR fixes it.

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaschoenburg lenaschoenburg

Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backup): collect metrics when for backup manager operations camunda/camunda
3 participants
@lenaschoenburg @deepthidevaki @Zelldon