-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To big Deployment can cause problems on distribution #5776
Comments
What does the user/client see in this case? Is this something users can "fix"? |
It looks like this is the error the user gets:
Which somewhat hints that it's a size issue, but I don't think it's very clear for the user what they have to do. I would argue this isn't deployment specific - any time we would fail to grab a segment on the dispatcher due to size, this will be an issue and this error will be returned. I imagine this can happen during processing of other commands as well (even if it's less likely). In this specific case, this could be solved by checking the size before even writing it to the dispatcher - since it's much bigger than a segment, it's pretty obvious it will fail. If it happens later during enriching this is then internal and it's a bit of a problem, and I'm not sure how it will end up being reported. imo this falls under the whole topic of dealing with maximum message sizes and so on, and I'd like to tackle that at a higher level. For this particular issue, I'm not sure how we could improve the report to the user, as this is a generic error handling. |
Seems to be no longer the case. @korthout tried to reproduce this issue during the preparation of a game day. I will close this for now. |
* feat(feature-flagged): add header for left diagram * refactor: rename computed value from isLastStep to isSummaryStep * chore: set IS_INSTANCE_MIGRATION_ENABLED to false
Describe the bug
If we reach with a deployment the
maxMessageSize
almost then we can get issues with the distributions, since theCREATE
command which will be distributed contains more content then the initialCREATE
. This means we deploy a workflow, which can only be started on partition one but not on other partitions.To Reproduce
model.zip
Expected behavior
That the deployment is rejected, maybe?
Environment:
The text was updated successfully, but these errors were encountered: