Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export evaluated DMN decisions/elements to Prometheus/Grafana #8805

Closed
Tracked by #8083
saig0 opened this issue Feb 17, 2022 · 1 comment · Fixed by #8836
Closed
Tracked by #8083

Export evaluated DMN decisions/elements to Prometheus/Grafana #8805

saig0 opened this issue Feb 17, 2022 · 1 comment · Fixed by #8836
Assignees
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog

Comments

@saig0
Copy link
Member

saig0 commented Feb 17, 2022

Description

With Zeebe 1.4.0, we support the evaluation of DMNs from business rule tasks. We want to track the usage of DMN by exporting the evaluated DMN decisions/elements as metrics to Prometheus/Grafana. The metric should be similar to the process instances metric zeebe.executed_instances_total.

There is related issue for zeebe-analytics: https://github.com/camunda-cloud/zeebe-analytics/issues/22

  • create a new metric: zeebe.evaluate_dmn_elements_total
    • with labels: organizationId, action, partition
    • with action as one of: evaluated_successfully, evaluated_failed
    • as metric type counter
  • increase the metric by one for each DMN element that is evaluated
    • if the called decision has no required decisions then the metric is increased by one
    • if the called decision has required decisions then the metric is increased by one and for each required decision recursively
    • the metric is increased by one independent of the type of decision (i.e. decision table = +1, decision literal expression = +1)
  • increase the metric with the label action: evaluated_successfully if the evaluation of the called DMN was successful, otherwise use the label action: evaluated_failed

blocked by #8115

@saig0 saig0 added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog labels Feb 17, 2022
@saig0 saig0 added this to Planned in Zeebe Feb 17, 2022
@saig0 saig0 added this to the Evaluate DMN decisions milestone Feb 17, 2022
@menski
Copy link
Contributor

menski commented Feb 17, 2022

let's only count the decision instances that were evaluated successfully and not the ones that are failed. this way we have it aligned with c7. does this work for you?

From a product perspective we only need to count successful evaluations for the decision value metrics, but I think it's nice to still have both counted as described in the issue. Console will then only use the successful executions for the value metric.

@saig0 saig0 moved this from Planned to In progress in Zeebe Feb 25, 2022
@saig0 saig0 moved this from In progress to Review in progress in Zeebe Feb 25, 2022
ghost pushed a commit that referenced this issue Feb 25, 2022
8836: Add decision element metrics r=menski a=menski

## Description

Adds new Prometheus metric to track successfully and failed evaluated DMN element.

Metric Name: `zeebe_evaluated_dmn_elements_total`
Metric Labels:
- `organizationId`
- `action`: `evaluated_successfully` or `evaluated_failed`
- `partition`
 
The metric tracks all evaluated decision including the required decisions.
This is aligned with Camunda 7 value metric EDE.

If a decision evaluation failed all required decision are also counted as failed for the metric.

## Related issues

closes #8805



Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
@ghost ghost closed this as completed in b470b4e Feb 25, 2022
Zeebe automation moved this from Review in progress to Done Feb 25, 2022
@KerstinHebel KerstinHebel removed this from Done in Zeebe Mar 23, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants