Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding processors and event appliers for non-engine records #9613

Closed
Tracked by #9606
deepthidevaki opened this issue Jun 27, 2022 · 0 comments · Fixed by #10071
Closed
Tracked by #9606

Allow adding processors and event appliers for non-engine records #9613

deepthidevaki opened this issue Jun 27, 2022 · 0 comments · Fixed by #10071
Assignees
@deepthidevaki
Labels
version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented Jun 27, 2022 •
edited
Loading

Depends #9612

Once StreamProcessor can differentiate between engine and non-engine records, we should be able to add new processors and event appliers for these records. Currently the event-appliers are part of engine. We should abstract it and take it out of engine.

Goal:
Refactor adding TypedRecordProcoessors in such a way that

  • We can register processors and event appliers defined by engine
  • We can also register processors and event appliers for non-engine records independent of the engine
@deepthidevaki deepthidevaki mentioned this issue Jun 27, 2022
Closed
58 tasks
This was referenced Jul 6, 2022
Closed
Closed
@pihme pihme mentioned this issue Jul 8, 2022
Closed
@deepthidevaki deepthidevaki self-assigned this Jul 28, 2022
@deepthidevaki deepthidevaki mentioned this issue Aug 15, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Aug 17, 2022
@zeebe-bors-camunda @deepthidevaki @remcowesterhoud
merge: #10071 #10088
190ce8c 
10071: StreamProcessor can choose between engine and non-engine records r=deepthidevaki a=deepthidevaki

## Description

This PR allows us to add more than one RecordProcessor in the StreamProcessor. Currently there is only one processor which is the `Engine`. After this PR, we can add checkpoint processor to the StreamProcessor. 

## Related issues

closes #9613 



10088: Indent yaml correctly r=npepinpe a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->
Fix indentation of the qa_testbench yaml file

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this issue Aug 17, 2022
@zeebe-bors-camunda @deepthidevaki
merge: #10071
1419ca7 
10071: StreamProcessor can choose between engine and non-engine records r=deepthidevaki a=deepthidevaki

## Description

This PR allows us to add more than one RecordProcessor in the StreamProcessor. Currently there is only one processor which is the `Engine`. After this PR, we can add checkpoint processor to the StreamProcessor. 

## Related issues

closes #9613 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StreamProcessor can choose between engine and non-engine records camunda/camunda
3 participants
@menski @deepthidevaki @Zelldon