Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send current checkpointId with all remote commands #9810

Closed
Tracked by #9606
deepthidevaki opened this issue Jul 14, 2022 · 0 comments · Fixed by #9891
Closed
Tracked by #9606

Send current checkpointId with all remote commands #9810

deepthidevaki opened this issue Jul 14, 2022 · 0 comments · Fixed by #9891
Assignees
@lenaschoenburg
Labels
version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

deepthidevaki commented Jul 14, 2022 •
edited
Loading

Every message send between partitions must encode the current checkpointId at the sender.

Depends on #9720 #9625 #9721
@deepthidevaki deepthidevaki mentioned this issue Jul 14, 2022
Closed
58 tasks
@lenaschoenburg lenaschoenburg self-assigned this Jul 26, 2022
@lenaschoenburg lenaschoenburg mentioned this issue Jul 26, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Jul 26, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #9891
2f9f0b1 
9891: Send current checkpoint id with inter-partition commands r=oleschoenburg a=oleschoenburg

## Description

The sender implements a `CheckpointListener`, updating an internalfield whenever a new checkpoint is created. For all commands, the current checkpoint id is sent along.

The sender is no longer thread-safe. Calls of the listener and the send methods must be linearized by the stream processor, otherwise commands could be sent with stale checkpoint ids.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #9810 



Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jul 26, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #9891
625d98e 
9891: Send current checkpoint id with inter-partition commands r=oleschoenburg a=oleschoenburg

## Description

The sender implements a `CheckpointListener`, updating an internalfield whenever a new checkpoint is created. For all commands, the current checkpoint id is sent along.

The sender is no longer thread-safe. Calls of the listener and the send methods must be linearized by the stream processor, otherwise commands could be sent with stale checkpoint ids.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #9810 



Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaschoenburg lenaschoenburg

Labels
version:8.1.0-alpha4 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send current checkpoint id with inter-partition commands camunda/camunda
4 participants
@npepinpe @lenaschoenburg @deepthidevaki @Zelldon