Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(raft): follower reset pendingsnapshot after rejecting install request #10183

Merged
merged 11 commits into from
Aug 29, 2022
Merged

fix(raft): follower reset pendingsnapshot after rejecting install request #10183

merged 11 commits into from
Aug 29, 2022

Commits on Aug 25, 2022

  1. test(raft): allow comparing compacted logs 

    When comparing compacted logs, not all entries exist in all logs. So compare only the entries that exist.
    @deepthidevaki
    deepthidevaki committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    773dfa2 View commit details
    Browse the repository at this point in the history

  2. test(raft): extend RandomizedRaftTest with snapshot and compaction

    @deepthidevaki
    deepthidevaki committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5db2932 View commit details
    Browse the repository at this point in the history

  3. fix(raft): reset snapshot replication on error in follower 

    When follower responds with any error, leader restarts send the snapshot from the initial chunk. When the follower has not resets its state, then the follower is not expecting the initial chunk. As a result, the follower reject the requests and this will continue endlessly.
    @deepthidevaki
    deepthidevaki committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9aba732 View commit details
    Browse the repository at this point in the history

  4. test(raft): write different content to each chunk to improve test rel… 

    …iability
    @deepthidevaki
    deepthidevaki committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    fe11e34 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. test(raft): improve assertion failure message

    @deepthidevaki
    deepthidevaki committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6a39814 View commit details
    Browse the repository at this point in the history

  2. fix(raft): reset log always on receiving a snapshot 

    There were some cases where the log is not reset and leads to scenarios where a follower is not able to replicate new events. This case is explained in #10183 (comment)
    @deepthidevaki
    deepthidevaki committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    4c82bd9 View commit details
    Browse the repository at this point in the history

  3. refactor(raft): remove unused snapshot listener

    @deepthidevaki
    deepthidevaki committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    43c96cd View commit details
    Browse the repository at this point in the history

  4. test(raft): improve assertion failure message

    @deepthidevaki
    deepthidevaki committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    d79b730 View commit details
    Browse the repository at this point in the history

  5. test(raft): remove unnecessary seek

    @deepthidevaki
    deepthidevaki committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    1362765 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. refactor(raft): fix typo in error message

    @deepthidevaki
    deepthidevaki committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    455a09c View commit details
    Browse the repository at this point in the history

  2. test(raft): allow snapshot with one chunk in randomized tests 

    Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
    @deepthidevaki @lenaschoenburg
    deepthidevaki and lenaschoenburg committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    69df0fa View commit details
    Browse the repository at this point in the history