Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.1] refactor(elasticsearch-exporter): output raw message on JSON error #10981

Merged
merged 2 commits into from
Nov 11, 2022
Merged

[Backport stable/8.1] refactor(elasticsearch-exporter): output raw message on JSON error #10981

merged 2 commits into from
Nov 11, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #10971 to stable/8.1.

relates to #10970

@npepinpe @github-actions
refactor(elasticsearch-exporter): output raw message on JSON error
469d21a 
Ensures that the raw message is printed as part of the stacktrace when
the server returns a successful, but invalid message, so we can more
easily diagnose what is happening.

(cherry picked from commit 7bca628)
@npepinpe @github-actions
refactor(elasticsearch-exporter): make explicit why we read the compl…
e4e722b 
…ete response

(cherry picked from commit fe5a75d)
@backport-action backport-action mentioned this pull request Nov 11, 2022
Merged
9 tasks
@github-actions
Copy link
Contributor

Test Results

   937 files  ±  0     937 suites  ±0   1h 40m 27s ⏱️ - 3m 6s
7 414 tests  - 54  7 406 ✔️  - 54  8 💤 ±0  0 ❌ ±0 
7 608 runs   - 54  7 600 ✔️  - 54  8 💤 ±0  0 ❌ ±0 

Results for commit e4e722b. ± Comparison against base commit 8715beb.

npepinpe
npepinpe approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 7d61538 into stable/8.1 Nov 11, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-10971-to-stable/8.1 branch November 11, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npepinpe npepinpe npepinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backport-action @npepinpe