Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docker): hint on BuildKit being required #11067

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Nov 22, 2022

Description

As found yesterday the recent changes to the Dockerfile introducing the TARGETARCH var require Docker BuildKit to be enabled.

@Zelldon
Copy link
Member

Zelldon commented Nov 22, 2022

Could you please announce this in the team channel as well? Since we all need to build the images for benchmarks or is there maybe a better way to do that? Like per default we build images which don't need it and in our release pipeline we only need to set it ? 🤔

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

Test Results

   958 files  ±    0     958 suites  ±0   1h 42m 39s ⏱️ -32s
7 855 tests +325  7 848 ✔️ +325  7 💤 ±0  0 ±0 
8 055 runs  +325  8 046 ✔️ +325  9 💤 ±0  0 ±0 

Results for commit 4f32709. ± Comparison against base commit 0ab1c7d.

♻️ This comment has been updated with latest results.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@megglos
Copy link
Contributor Author

megglos commented Nov 22, 2022

Could you please announce this in the team channel as well? Since we all need to build the images for benchmarks or is there maybe a better way to do that?

Will do, thanks for the reminder!

Like per default we build images which don't need it and in our release pipeline we only need to set it ? 🤔

With the current state of the Dockerfile a local docker build might fail if BuildKit is not enabled as it can't resolve the used variable which is only provided if BuildKit is enabled.
As going forward Docker intents to replace the legacy builder with BuildKit, I think it's generally fine (and actually recommended) to enable it by default also on Linux, see BuildKit provides many enhancements over the classic builder [..] is overall recommended to be used if supported on the user's platform. moby/moby#40379 .

@megglos
Copy link
Contributor Author

megglos commented Nov 22, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit e704573 into main Nov 22, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the meg-docker-buildkit-docs branch November 22, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants