Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] fix(cluster): do no use channel created for a different address #12376

Merged
merged 4 commits into from
Apr 14, 2023
Merged

[Backport stable/8.0] fix(cluster): do no use channel created for a different address #12376

merged 4 commits into from
Apr 14, 2023

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #12305 to stable/8.0.

relates to #12173

@backport-action backport-action mentioned this pull request Apr 12, 2023
Merged
14 tasks
@deepthidevaki deepthidevaki self-assigned this Apr 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

Test Results

   787 files   -   83     787 suites   - 83   1h 52m 59s ⏱️ - 5m 9s
5 736 tests  - 631  5 729 ✔️  - 632  6 💤 ±0  1 ❌ +1 
5 880 runs   - 643  5 873 ✔️  - 644  6 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit bdcd4a6. ± Comparison against base commit 1049ce8.

This pull request removes 1008 and adds 377 tests. Note that renamed tests count towards both. 
DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={z=[1, 2, 3], y=true, x=1}
MetricsExporterTest MetricsExporter should configure a Filter ‑ accepting records of specific RecordType and ValueType[1] combination=TypeCombination[recordType=EVENT, valueType=JOB]
MetricsExporterTest MetricsExporter should configure a Filter ‑ accepting records of specific RecordType and ValueType[2] combination=TypeCombination[recordType=EVENT, valueType=JOB_BATCH]
MetricsExporterTest MetricsExporter should configure a Filter ‑ accepting records of specific RecordType and ValueType[3] combination=TypeCombination[recordType=EVENT, valueType=PROCESS_INSTANCE]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[100] combination=TypeCombination[recordType=NULL_VAL, valueType=VARIABLE]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[101] combination=TypeCombination[recordType=NULL_VAL, valueType=VARIABLE_DOCUMENT]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[102] combination=TypeCombination[recordType=NULL_VAL, valueType=PROCESS_INSTANCE_CREATION]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[103] combination=TypeCombination[recordType=NULL_VAL, valueType=ERROR]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[104] combination=TypeCombination[recordType=NULL_VAL, valueType=PROCESS_INSTANCE_RESULT]
MetricsExporterTest MetricsExporter should configure a Filter ‑ rejecting records of specific RecordType and ValueType[105] combination=TypeCombination[recordType=NULL_VAL, valueType=PROCESS]
…

DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={x=1, z=[1, 2, 3], y=true}
io.atomix.cluster.messaging.impl.ChannelPoolTest ‑ shouldNotUseIncorrectChannelWhenIPReused
io.atomix.cluster.messaging.impl.ChannelPoolTest ‑ shouldNotUseOldChannelWhenIPChanged
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[0: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@5ab2c5d8]
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[1: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@5ec75178]
io.camunda.zeebe.engine.processing.bpmn.subprocess.EmbeddedSubProcessTest ‑ shouldNotTriggerBoundaryEventWhenFlowscopeIsInterrupted (Flaky Test)
io.camunda.zeebe.engine.processing.streamprocessor.ProcessExecutionRandomizedPropertyTest ‑ shouldExecuteProcessToEnd[TestDataRecord{processSeed=-3327485312070084733, executionPathSeed=3348794838176304984}]
io.camunda.zeebe.engine.processing.streamprocessor.ProcessExecutionRandomizedPropertyTest ‑ shouldExecuteProcessToEnd[TestDataRecord{processSeed=-4936003994722081068, executionPathSeed=-2953694784432906456}]
io.camunda.zeebe.engine.processing.streamprocessor.ProcessExecutionRandomizedPropertyTest ‑ shouldExecuteProcessToEnd[TestDataRecord{processSeed=-4936003994722081068, executionPathSeed=-3102072853571346857}]
io.camunda.zeebe.engine.processing.streamprocessor.ProcessExecutionRandomizedPropertyTest ‑ shouldExecuteProcessToEnd[TestDataRecord{processSeed=-4936003994722081068, executionPathSeed=-3393556869075844693}]
…

♻️ This comment has been updated with latest results.

@deepthidevaki deepthidevaki mentioned this pull request Apr 13, 2023
Merged
14 tasks
@deepthidevaki
Copy link
Contributor

There is a flaky test which would be fixed by #12397

@deepthidevaki
fix(cluster): do not use channel created for a different address
7451509 
When only using IP to find a channel pool, we observed that a channel pool
created for a node is re-used by another node which got its old ip. This
could lead to unexpected situations, where messages are sent to wrong node.

To fix this, we now use both address and ip to find a channel pool. In a
setup where restarts and ip re-assignment is common, it is safer this way.

(cherry picked from commit 943f014)
@deepthidevaki
test(cluster): verify channel mapping for different nodes
3adf643 
(cherry picked from commit 838c0c9)
@deepthidevaki
fix(cluster): remove closed channel from channel pool
9c6f0ee 
(cherry picked from commit 208441b)
@deepthidevaki
style(cluster): refactor to reduce nested if-else
bdcd4a6 
(cherry picked from commit 7c7dccc)
deepthidevaki
deepthidevaki approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 14, 2023
@zeebe-bors-camunda @deepthidevaki
merge: #12376
e2f2077 
12376: [Backport stable/8.0] fix(cluster): do no use channel created for a different address r=deepthidevaki a=backport-action

# Description
Backport of #12305 to `stable/8.0`.

relates to #12173

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor

Known flaky test #11844

@deepthidevaki
Copy link
Contributor

bors retry

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 14, 2023
@zeebe-bors-camunda @deepthidevaki
merge: #12376
ea3b506 
12376: [Backport stable/8.0] fix(cluster): do no use channel created for a different address r=deepthidevaki a=backport-action

# Description
Backport of #12305 to `stable/8.0`.

relates to #12173

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@deepthidevaki
Copy link
Contributor

The self-hosted runner: lost communication with the server.

bors retry

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 2218a05 into stable/8.0 Apr 14, 2023
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-12305-to-stable/8.0 branch April 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees

@deepthidevaki deepthidevaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backport-action @deepthidevaki