feat: default to a better raft request timeout #12421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the old default values of:
```yaml
zeebe.broker:
cluster:
electionTimeout: 2.5s
raft:
enablePriorityElection: true
experimental:
maxAppendsPerFollower: 2
raft:
requestTimeout: 5s
```
the loss of 2 requests between primary(leader) and secondary(follower)
could trigger unnecessary re-election because the secondary would not
receive any requests from the primary for at least 5 seconds which
exceeds election timeout.
This changes the default request timeout to always match the default
election timeout. Using all default values, we get at least one more
request attempt between primary and secondary before re-election and
probably more, depending on the exact timing when requests are sent.
Test Results1 054 files ± 0 1 054 suites ±0 2h 3m 19s ⏱️ + 4m 43s Results for commit 25a334d. ± Comparison against base commit d1cd172. This pull request removes 388 and adds 462 tests. Note that renamed tests count towards both. |
deepthidevaki
approved these changes
Apr 14, 2023
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the old default values of:
the loss of 2 requests between primary(leader) and secondary(follower) could trigger unnecessary re-election because the secondary would not receive any requests from the primary for at least 5 seconds which exceeds election timeout.
This changes the default request timeout to always match the default election timeout. Using all default values, we get at least one more request attempt between primary and secondary before re-election and probably more, depending on the exact timing when requests are sent.
closes #12009