Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.2] fix: do not retake backup if it already exists #12656

Merged
merged 3 commits into from
May 3, 2023

Commits on May 3, 2023

  1. fix(backup): do not take backup when one already exists

    Previously, we were only checking for backups taken by this node.
    However, there could be backups taken by another node. For example, after
    restore the checkpoint record is processed again, but it must not re-take
    the backup. To prevent that, we should check for all backups with the given
    backup id.
    
    (cherry picked from commit a886d80)
    deepthidevaki authored and github-actions[bot] committed May 3, 2023
    Configuration menu
    Copy the full SHA
    76aed29 View commit details
    Browse the repository at this point in the history
  2. test(backup): verify backup is not re-taken when already exist

    Updated the test to remove mocking of InProgressBackup. The existing test
    was updated to use list instead of getStatus to find duplicate backups.
    
    (cherry picked from commit 8763717)
    deepthidevaki authored and github-actions[bot] committed May 3, 2023
    Configuration menu
    Copy the full SHA
    09b2e0d View commit details
    Browse the repository at this point in the history
  3. refactor(backup): use existing comparator

    Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
    (cherry picked from commit 65e08d9)
    deepthidevaki authored and github-actions[bot] committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4a262ca View commit details
    Browse the repository at this point in the history