feat(client): provide the Java client's interfaces for migrating a process instance #15199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Dismissed
Show dismissed
Hide dismissed
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Fixed
Show fixed
Hide fixed
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Dismissed
Show dismissed
Hide dismissed
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Dismissed
Show dismissed
Hide dismissed
korthout
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Nice work @berkaycanbc 🙌
👍 I really like the examples in the command method's JavaDoc. They inspire me to ask for more of these in other places.
❌ There are a few small things that I believe should be changed.
🔧 I also made some suggestions. Please have a look.
clients/java/src/main/java/io/camunda/zeebe/client/ZeebeClient.java
Outdated
Show resolved
Hide resolved
clients/java/src/main/java/io/camunda/zeebe/client/ZeebeClient.java
Outdated
Show resolved
Hide resolved
clients/java/src/main/java/io/camunda/zeebe/client/ZeebeClient.java
Outdated
Show resolved
Hide resolved
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Show resolved
Hide resolved
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Outdated
Show resolved
Hide resolved
clients/java/src/main/java/io/camunda/zeebe/client/api/command/MigrationPlan.java
Outdated
Show resolved
Hide resolved
...va/src/main/java/io/camunda/zeebe/client/impl/command/MigrateProcessInstanceCommandImpl.java
Outdated
Show resolved
Hide resolved
berkaycanbc
commented
Nov 16, 2023
There was a problem hiding this comment.
Great feedback @korthout, thanks! 😍
I sent changes based on your comments. 👍
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Dismissed
Show dismissed
Hide dismissed
korthout
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Thanks for the changes @berkaycanbc ❤️
I have a few last suggestions, but nothing major. Please have a look.
LGTM 👍
clients/java/src/main/java/io/camunda/zeebe/client/ZeebeClient.java
Outdated
Show resolved
Hide resolved
...va/src/main/java/io/camunda/zeebe/client/api/command/MigrateProcessInstanceCommandStep1.java
Outdated
Show resolved
Hide resolved
clients/java/src/main/java/io/camunda/zeebe/client/api/command/MigrationPlan.java
Outdated
Show resolved
Hide resolved
berkaycanbc
force-pushed
the
bcan-15161-provide_the_java_clients_interfaces_for_migrating_a_process_instance
branch
2 times, most recently
from
2915c67
to
1be8626
Compare
A MigrationPlan object and its builder is added. The MigrationPlan object can be reused to migrate different process instances with the same active elements that needs to be migrated to the same process definition.
Steps are structured in a way that they force users to follow required order. E.g. targetProcessDefinitionKey needs to be provided before mappingInstructions. Also, addMappingInstruction method is duplicated in both step 2 and final step. This is because we still want to be able to add intermediate steps to the command chain using step 2 interface.
…gration The implementation of process instance migration command left unimplemented because no actual implementation is available in the engine at the moment.
Tests only verify the command chain at the moment. Later will be updated once actual implementation takes place in the engine.
berkaycanbc
force-pushed
the
bcan-15161-provide_the_java_clients_interfaces_for_migrating_a_process_instance
branch
from
1be8626
to
8a5e443
Compare
korthout
approved these changes
Nov 17, 2023
|
bors merge |
|
Build succeeded: |
zeebe-bors-camunda
bot
closed this pull request by merging all changes
into
main
in
8b70dcd
zeebe-bors-camunda
bot
deleted the
bcan-15161-provide_the_java_clients_interfaces_for_migrating_a_process_instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #15161
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.