Feat: Add endpoint to configure and get flow control #19409
+739
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/zeebe
For this test the set and get method are using different decoders, for which I think the easiest solution is to use two different Feign actuators with an abstraction in between, I was not able to find something more simple or elegant.
rodrigo-lourenco-lopes
force-pushed
the
rl-add-endpoint-to-configure-flow-control
branch
from
434bda8
to
f3f1c97
Compare
lenaschoenburg
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Nice work @rodrigo-lourenco-lopes 🥇
I have a couple of suggestions and things I'd like to see changed but nothing major 🎉
dist/src/main/java/io/camunda/zeebe/shared/management/FlowControlEndpoint.java
Outdated
Show resolved
Hide resolved
zeebe/qa/util/src/main/java/io/camunda/zeebe/qa/util/actuator/SetFlowControlActuator.java
Outdated
Show resolved
Hide resolved
dist/src/main/java/io/camunda/zeebe/shared/management/FlowControlServiceImpl.java
Outdated
Show resolved
Hide resolved
...roker/src/main/java/io/camunda/zeebe/broker/system/partitions/ZeebePartitionAdminAccess.java
Outdated
Show resolved
Hide resolved
zeebe/protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/AdminRequest.java
Outdated
Show resolved
Hide resolved
zeebe/logstreams/src/main/java/io/camunda/zeebe/logstreams/impl/flowcontrol/FlowControl.java
Outdated
Show resolved
Hide resolved
zeebe/protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/AdminRequest.java
Outdated
Show resolved
Hide resolved
zeebe/protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/AdminResponse.java
Outdated
Show resolved
Hide resolved
...qa/integration-tests/src/test/java/io/camunda/zeebe/it/management/FlowControlEndpointIT.java
Outdated
Show resolved
Hide resolved
...qa/integration-tests/src/test/java/io/camunda/zeebe/it/management/FlowControlEndpointIT.java
Show resolved
Hide resolved
rodrigo-lourenco-lopes
force-pushed
the
rl-add-endpoint-to-configure-flow-control
branch
from
7d361c4
to
8bc87bf
Compare
lenaschoenburg
requested changes
Jul 1, 2024
zeebe/protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/AdminRequest.java
Outdated
Show resolved
Hide resolved
zeebe/protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/AdminResponse.java
Outdated
Show resolved
Hide resolved
lenaschoenburg
requested changes
Jul 2, 2024
There was a problem hiding this comment.
❌ the actuator is still responding in plain text:
curl -v localhost:9600/actuator/flowControl
* Host localhost:9600 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
* Trying [::1]:9600...
* Connected to localhost (::1) port 9600
> GET /actuator/flowControl HTTP/1.1
> Host: localhost:9600
> User-Agent: curl/8.6.0
> Accept: */*
>
< HTTP/1.1 200
< Content-Type: text/plain;charset=UTF-8
< Content-Length: 177
< Date: Tue, 02 Jul 2024 13:48:38 GMT
<
* Connection #0 to host localhost left intact
{"partitions":[{"flowControlConfig":"{REQUEST=com.netflix.concurrency.limits.limit.WindowedLimit@113ef35e, APPEND=VegasLimit [limit=1024, rtt_noload=0.0 ms]}","partitionId":1}]}
❌ The windowed limit is not serialized properly.
I think the serialization approach is not great overall, I'll take a look to try and find a way to make this look nice and maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds an endpoint to set and get the flow control configuration.
The get method returns the several flow control limits configured for each partition and broker.
The set method will use the configuration that we send in the payload in JSON to set the limits of all partitions in all brokers. To note that since the append limit cannot be null, if this is not present in the JSON payload or is set as null, then it will not be changed. In case the JSON is not parseable to the object FlowControl configuration, the error message will be return along with an example of a configuration.
Related issues
closes #18731